Use props/ directory directly #813
Conversation
Using <Import> in csproj file that lay not at two dirs deep of any subproject cause warnings about missing file.
|
👍 improvement |
|
The SolutionDir variable is made for this exact purpose. If it's not working, we'd better fix that instead. |
|
Wait is it just warnings it's throwing, not errors? If so I think it's best to just ignore the warnings, and use the current variable. |
|
Just a warning about missing file
Never ignore warnings |
|
Yes but if the warning is just a false-positive, then there's no problem. The file obviously exists. |
|
Which file is raising the warning? If it's just the stylecop reference, use SolutionDir there. |
|
$(SolutionDir) is set only when you build complete solution, but I usually build single csproj |
|
And when you build a single csproj, does the issue fixed by this PR break the build, or does it continue regardless? |
This pr don't break build. |
|
So building a single csproj works fine then? |
|
Yeap, but it's looks like dotnet-cli issue. Docs(online) didn't specify that you can build solution, and it will be good to have -p flag to pick project |
|
Given that this doesn't affect build, this PR is more a nitpick than necessity and, as such, isn't really needed. |
|
Of course it doesn't broke build, it just allow you to build single project without building others, and many of them are completely separate, like Rewrited, Windows native bindings |
|
The OpenAL PR also addresses this issue by defining its own solution root variable, and using a single relative path from each project to import the common properties where it lives. |
|
To be honest, I'm against this being merged for reasons we've both already stated. |
|
I can't believe nobody said this, but thanks as always @VPeruS. We appreciate every contribution, even the ones that don't make it! |
Using in csproj file that lay not at two dirs deep of any subproject cause warnings about missing file.