[4.0] Embedded license handling for binding generator #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a ton! I'll leaf through it and give you some feedback :) Fair warning, I'm a nitpicky arse :P |
Nihlus
suggested changes
Oct 30, 2018
|
Looks like a solid approach - I like it. Some layout issues, spotted a bug, and had a thought about using Lazy instead of manually checking a backing field. |
|
@DylanFPS Is there a rule for testing internal classes (e.g. location in the source tree, language used) etc.? |
|
Just make sure it works, and do it however. And make sure you delete all testing code after you’ve verified it works. |
* Renamed LicenseResource to EmbeddedResources. * Removed Property LicenseText from GeneratorSettings classes. * Modified BindingWriter to access the license text via embedded resources.
Perksey
approved these changes
Nov 1, 2018
Nihlus
approved these changes
Nov 1, 2018
|
Thanks for the contribution @dnstag - We really hope to see more of this in the future! |
|
You will! I'm glad i could help. :) |
|
[WIP] must be removed |
Perksey
changed the title
|
@VPeruS Thanks. We just added a check for that before merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
As of #829, the
LicenseTextproperty inGeneratorSettingsBase(including parent and child classes) contains actual license data which should be in another place. This PR will implement a class which loads the license file as an embedded resource acessible via property and changes affected classes accordingly.The PR is marked as WIP as this is my first PR, so please feel free to review and discuss as i commit more changes.
Oh and please... be gentle. :)
Testing status
Sucessfully tested with the text in Specifications/License.txt.
Related
Resolves #829