Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Begin moving Input to OpenTK.Input #861

Closed
wants to merge 12 commits into from
Closed

[4.0] Begin moving Input to OpenTK.Input #861

wants to merge 12 commits into from

Conversation

devvoid
Copy link
Contributor

@devvoid devvoid commented Nov 18, 2018

Purpose of this PR

  • Description of feature/change: Move all input-related code out of OpenTK and into OpenTK.Input.
  • Which part of OpenTK does this affect: Input.
  • Links to screenshots, design docs, user docs, etc: None yet.

Testing status

  • No testing as of yet.

Comments

  • None.

@devvoid
Copy link
Contributor Author

devvoid commented Nov 18, 2018

Since Input depends on Platform, this is on hold until OpenTK.Platform is separated.

@devvoid
Copy link
Contributor Author

devvoid commented Nov 18, 2018

Last commit name is somewhat misleading. The mouse classes used floats internally, but for some reason casted them to ints when returning to the user. That just updates the getters/setters to use floats for consistancy's sake.

@Perksey
Copy link
Contributor

Perksey commented Nov 18, 2018

Awesome! Will see what the rest of the team think about using ADL instead of the rewriter (#854) before I make my OpenGL PR.

@Perksey Perksey added the input label Nov 18, 2018
@varon varon added this to In Progress in OpenTK 4.0 Nov 23, 2018
@Perksey
Copy link
Contributor

Perksey commented Dec 19, 2018

FTR: this PR is now blocked by the GLFW PR at #867.

@devvoid
Copy link
Contributor Author

devvoid commented Jan 2, 2019

This has been discussed on the official Discord a while back, but I want to put it here just for clarity.

The plan for this PR is just a quick and dirty port of Input to work with the new GLFW-based windowing system. However, Input has a lot of problems, old code, and things that don't work.

After the simple port job is finished, I'll work on giving Input the love and attention it needs in a separate PR, maybe for 4.0, maybe for 5.0 (depending on how far along the rest of the project is by the time I get there). This should hopefully modernize the code and fix several longstanding issues.

This is just the current plan, it may change depending on how much modification is necessary to use GLFW instead of SDL/native.

@Perksey
Copy link
Contributor

Perksey commented Jan 3, 2019

A 4.1 can always be made for input if its just a fixer-upper and doesn't change any of the public API surface, don't forget that each subsystem is versioned independently (at the minor level), but I think we just need to get 4.0 out as fast as possible at the moment.

With OpenTK dropping native platforms in favor of GLFW, which lacks the ability to retrieve the keyboard name, this function is impossible to implement
Nobody on the Discord seems to know what this supposed "unimplemented API" was supposed to be, I can't find any mentions of it anywhere, and the Keyboard/KeyboardState classes look like they should function just fine.
@devvoid
Copy link
Contributor Author

devvoid commented Feb 6, 2019

I had to delete the fork this was based on so I could clone the repo for #867 and help out there. Saved a diff of all the changes there, will reopen with a new PR when GLFW is ready to go.

@devvoid devvoid closed this Feb 6, 2019
@frederikja163 frederikja163 changed the title [WIP] [4.0] Begin moving Input to OpenTK.Input [4.0] Begin moving Input to OpenTK.Input Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
OpenTK 4.0
  
In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants