Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Begin moving Platform to OpenTK.Platform #862

Closed
wants to merge 5 commits into from
Closed

[4.0] Begin moving Platform to OpenTK.Platform #862

wants to merge 5 commits into from

Conversation

devvoid
Copy link
Contributor

@devvoid devvoid commented Nov 18, 2018

Purpose of this PR

  • Description of feature/change: Move all platform-related code out of OpenTK and into OpenTK.Platform.
  • Which part of OpenTK does this affect (Math, OpenGL, Platform, Input, etc): Platform
  • Links to screenshots, design docs, user docs, etc: None yet

Testing status

  • None yet.

Comments

  • None.

@devvoid
Copy link
Contributor Author

devvoid commented Nov 18, 2018

Since Platform depends on Graphics, this is on hold until Graphics is separated.

@Perksey
Copy link
Contributor

Perksey commented Nov 18, 2018

I'll do this when I make my OpenGL PR, it doesn't make sense to just move graphics and then do the platforms separately. Keep up the good work though!

@varon varon added this to In Progress in OpenTK 4.0 Nov 23, 2018
Perksey
Perksey suggested changes Nov 25, 2018
View reviewed changes
Copy link
Contributor

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik, GLFW (#867) replaces Platform in its entirety, so this PR isn't needed. Maintainers correct me if I'm wrong here! :P

@Perksey Perksey closed this Nov 30, 2018
@devvoid devvoid deleted the move_platform branch January 21, 2019 20:31
@frederikja163 frederikja163 changed the title [WIP] [4.0] Begin moving Platform to OpenTK.Platform [4.0] Begin moving Platform to OpenTK.Platform Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey requested changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OpenTK 4.0
  
In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devvoid @Perksey