Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Unsafe.As optimization to all vector types #878

Merged
merged 2 commits into from
Jan 13, 2019
Merged

Apply Unsafe.As optimization to all vector types #878

merged 2 commits into from
Jan 13, 2019

Conversation

devvoid
Copy link
Contributor

@devvoid devvoid commented Jan 13, 2019

Purpose of this PR

Testing status

  • Built it, tested it to make sure that it works, that's about it.

Perksey
Perksey approved these changes Jan 13, 2019
View reviewed changes
Copy link
Contributor

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, should go miles for performance! 👍

@Perksey Perksey changed the title Apply Unsafe.As optimization to all vector types Apply Unsafe.As optimization to all vector types wip Jan 13, 2019
@Perksey Perksey changed the title Apply Unsafe.As optimization to all vector types wip Apply Unsafe.As optimization to all vector types Jan 13, 2019
Perksey
Perksey suggested changes Jan 13, 2019
View reviewed changes
Copy link
Contributor

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error SA1210: Using directives should be ordered alphabetically by the namespaces. See the latest AppVeyor build for more info.

@Perksey Perksey merged commit a11eda4 into opentk:master Jan 13, 2019
@devvoid devvoid deleted the vector_conversion_optimizations branch January 21, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devvoid @Perksey