Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purity annotations for Math types #915

Merged
merged 17 commits into from
Jun 6, 2019
Merged

Purity annotations for Math types #915

merged 17 commits into from
Jun 6, 2019

Conversation

ImDreamerDev
Copy link
Contributor

@ImDreamerDev ImDreamerDev commented May 27, 2019 •
edited by varon
Loading

Purpose of this PR

@ImDreamerDev ImDreamerDev changed the title Start on Purity annotations for Math types [WIP] Start on Purity annotations for Math types May 27, 2019
@Perksey
Copy link
Contributor

Perksey commented May 27, 2019

Thanks for championing this! Give it a few days and we should have #912 merged. :)

@varon
Copy link
Member

varon commented May 28, 2019

#912 is merged. You're free to go ahead!

@ImDreamerDev ImDreamerDev changed the title [WIP] Start on Purity annotations for Math types [WIP] Purity annotations for Math types May 29, 2019
@varon
Copy link
Member

varon commented May 30, 2019

Great work so far. Looking forward to getting these in!

@ImDreamerDev
Copy link
Contributor Author

Thanks, I'm hoping I'll have the time to finish it this weekend.

@ImDreamerDev ImDreamerDev changed the title [WIP] Purity annotations for Math types Purity annotations for Math types Jun 1, 2019
@Perksey
Copy link
Contributor

Perksey commented Jun 3, 2019

@varon Looks like this is ready for review.

@ImDreamerDev
Copy link
Contributor Author

ImDreamerDev commented Jun 3, 2019 •
edited
Loading

Oh sorry forgot to comment, that it is ready for review.

jvbsl
jvbsl requested changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@jvbsl jvbsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's everything I found.
If the implementations of the functions actually do what they should, then the Pure-annotations in this PR should be correct as well.
Did not search for missing ones though^^

src/OpenToolkit.Mathematics/Matrix/Matrix3x4.cs Outdated Show resolved Hide resolved
@Perksey
Copy link
Contributor

Perksey commented Jun 6, 2019

Approved, just fix merge conflicts. Some methods you've added the [Pure] attribute to may have been removed in another PR.

@ImDreamerDev
Copy link
Contributor Author

Gonna fix that now, I'm also going to add [Pure] to the new methods.

@ImDreamerDev ImDreamerDev changed the title Purity annotations for Math types [WIP] Purity annotations for Math types Jun 6, 2019
@ImDreamerDev ImDreamerDev changed the title [WIP] Purity annotations for Math types Purity annotations for Math types Jun 6, 2019
@ImDreamerDev
Copy link
Contributor Author

@Perksey Merge conflicts and the new methods should be covered and fixed.

@varon varon merged commit bdbcb13 into opentk:master Jun 6, 2019
@varon
Copy link
Member

varon commented Jun 6, 2019

Thanks for the excellent work @Lasser01 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

@jvbsl jvbsl jvbsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ImDreamerDev @Perksey @varon @jvbsl