Add API to let users pick OpenGL version #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvbsl
reviewed
May 31, 2019
src/Windowing/OpenToolkit.Windowing.Common/Enums/OpenGLVersion.cs
Outdated
Show resolved
Hide resolved
Perksey
reviewed
May 31, 2019
There was a problem hiding this comment.
Mentioned this in Discord, but thought I'd mention it here.
Don't forget we changed the way we bake profiles in 4.0.
- OpenToolkit.OpenGL contains OpenGL 1.0 through OpenGL 4.6
- OpenToolkit.OpenGL.Core contains OpenGL 1.0 through OpenGL 4.6, core profile
- OpenToolkit.OpenGLES contains OpenGLES 1.0 through OpenGLES 3.2
Obsolete functions are marked as such, except in core profile where obsolete functions are removed. This GLVersion would be used for windowing only, and no way affect the bindings.
Perksey
reviewed
May 31, 2019
src/Windowing/OpenToolkit.Windowing.Common/Enums/OpenGLVersion.cs
Outdated
Show resolved
Hide resolved
devvoid
changed the title
|
This is ready for review. |
Perksey
reviewed
Jun 1, 2019
src/Windowing/OpenToolkit.Windowing.Common/Enums/ContextFlags.cs
Outdated
Show resolved
Hide resolved
|
Done. |
Perksey
reviewed
Jun 2, 2019
|
Done! |
Perksey
approved these changes
Jun 2, 2019
varon
requested changes
Jun 2, 2019
|
Finished. |
varon
approved these changes
Jun 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Testing status
Comments