Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binder script paths #924

Merged
merged 2 commits into from
Jun 6, 2019
Merged

Fix binder script paths #924

merged 2 commits into from
Jun 6, 2019

Conversation

devvoid
Copy link
Contributor

@devvoid devvoid commented Jun 6, 2019

Purpose of this PR

  • On Linux Mint, update-specifications.bat and update-bindings.bat don't work because of the use of lowercase paths. This PR changes them to properly run.
  • Affects Generators.
  • No docs required.

Testing status

  • It runs.

Comments

  • No additional comments.

Perksey
Perksey approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but should we consider adding some .sh scripts for these?

@Perksey Perksey merged commit 70c36ad into opentk:master Jun 6, 2019
@devvoid devvoid deleted the binder_script_paths branch June 6, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devvoid @Perksey