Feature/fix box contains #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jvbsl
commented
Aug 20, 2019
jvbsl
commented
- Use latest C# version(necessary for me with dotnet 3.0 preview, doesn't seem to recognize 7.3)
- Make contains boundary exclusive, as tests do test for that -> fixed tests by doing that
- Make contains overload with bool parameter to test boundary inclusive as well
- Use boundary inclusive contains for inflate tests
* box contains check is non boundary inclusive by default now * Fixed box contains tests * Add boundary inclusive box contains check * Use boundary inclusive box contains check for inflate test
|
|
||
| [<Property>] | ||
| let ``Box2.Inflate is equivelant to Box2.Inflated`` (b1 : Box3, v1 : Vector3) = | ||
| let ``Box2.Inflate is equivalent to Box2.Inflated`` (b1 : Box3, v1 : Vector3) = |
There was a problem hiding this comment.
lol that change, hilarious. Good catch! 🥇
|
We've got a little code duplication here; the overload should probably defer to the other method. I'll merge for now as this fixes our tests! |
|
Thanks a ton @jvbsl ! |
|
the code duplication was on purpose for now, for performance, and I didn't want to AggressiveInline everything :D |
|
Figures. Hence the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.