Clean up window properties/interfaces. #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows interfaces have been collapsed into IGameWindow/INativeWindow. Removed/updated some properties on NativeWindowSettings to make more sense. Fixed some property applications such as visibility being AFTER window creation.
varon
reviewed
Oct 2, 2019
| @@ -15,7 +15,7 @@ namespace OpenToolkit.Windowing.Common | |||
| /// <summary> | |||
| /// Defines the interface for a GameWindow. | |||
There was a problem hiding this comment.
This is the most hilariously bad doc comment ever.
Can we briefly explain how IGameWindow differs from INativeWindow?
"IGameWindow provides a game update loop and corresponding events on top of INativeWindow"
There was a problem hiding this comment.
I'd prefer doing that in another PR, since I'll probably touch the exact separation between Game and NativeWindow anyways, it'd be better to do it then.
src/Windowing/OpenToolkit.Windowing.Common/Interfaces/INativeWindow.cs
Outdated
Show resolved
Hide resolved
|
Build seems to be failing when generating the bindings, could you try to restart the build @varon? |
varon
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows interfaces have been collapsed into IGameWindow/INativeWindow.
Removed/updated some properties on NativeWindowSettingsto make more sense.
Fixed some property applications such as visibility being AFTER window creation.