GLFW API cleanup. #989
Merged
GLFW API cleanup. #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tooling is only used for building the project, and opentk#976 also targets netcoreapp3.0.
Basically solves the TODOs I left in GLFW.cs I made *Raw versions of all methods that have a "raw-er" version, using pointers or byte buffers instead of ref/out/strings/arrays.
PJB3005
force-pushed
the
19-12-13-glfw-api-cleanup
branch
from
5963bd0
to
c99dce2
Compare
Also more stuff to try fixing FAKE.
I didn't realize AssemblyInfo.cs was gitignore'd so I didn't commit these attributes. That explains why the build failed like this. Should all be fixed now.
1. CopyBinaries has been disabled since it doesn't work and isn't necessary for packaging anymore. 2. Fixed it doing bindings generation twice (thrice generating NuGet packages) by building OpenGL_Bindings.csproj which then builds it all again. 3. Fixed NuGet packages being output to Bin/ instead of bin/, note the case difference.
frederikja163
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically solves the TODOs I left in GLFW.cs
I made *Raw versions of all methods that have a "raw-er" version, using pointers or byte buffers instead of ref/out/strings/arrays.
Merge #988 first.