-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action v0.0.1 #2
Conversation
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
…nition. Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I basically have a lot of questions
but I think it looks good
see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <admin@dkisler.com>
see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <admin@dkisler.com>
details: - opentofu#2 (comment) - opentofu#2 (comment) - opentofu#2 (comment) Signed-off-by: Dmitry Kisler <admin@dkisler.com>
see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <admin@dkisler.com>
see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
…matrix - tofu-wrapper flag. chore: adjusted version selection test selection. Signed-off-by: Dmitry Kisler <admin@dkisler.com>
…t tests. Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, but I think this needs some cleaning up.
@Yantrio Hey James! Thanks a lot for your review - I'll go through your comments thoroughly later today if you don't mind. A summarized reply to many of them: big part of the codebase was copied from setup-terraform without modification, hence the status quo may create some confusion and lead to the comments like "what year is it" 😀 I'll implement your suggestions, however we could also iteratively refactor after releasing v0.0.1 of the action so people could start using it already. For context, I intentionally did not invest effort into refactoring now to avoid postponing the action release. WDYT? |
@kislerdm Thanks for the quick reply and your efforts here! I trust your judgement on my comments here to change what you think needs changing. Most of these are small nitpicks and can be easily fixed or changed. for anything substantial requiring some refactoring and re-working, let's do it after in another PR. We can work together to make issues on things you want to do post-PR once you've had another go over my comments. Thanks again! 🙌 |
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
see: -opentofu#2 (comment) - opentofu#2 (comment) Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
@Yantrio Hey James! Could you please have a look at the changes I made following your suggestions. Thanks! |
I'm happy to approve and we can do more work in other issues/PRs later, I would just like these 2 comments addressing please :) https://github.com/opentofu/setup-opentofu/pull/2/files#r1356483075 Thanks! |
see: https://github.com/opentofu/setup-opentofu/pull/2/files#r1356483075 Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
@Yantrio Hey James, these comments have been addressed. Please let me know if there are more blockers which shall be tackled before the PR can be merged. Thanks! |
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Resolves opentofu/opentofu#556
What changed
lib/releases.js
.Why do we need it
cc: @eranelbaz @cube2222