Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end encryption when creating session. #327

Merged
merged 10 commits into from
May 9, 2023

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Feb 21, 2023

This PR adds the end to end encryption flag when starting an OpenTok Session.

Description

See the docs for more context:
https://tokbox.com/developer/guides/end-to-end-encryption/

Motivation and Context

New features being rolled into our SDKs

How Has This Been Tested?

Added new test and modified existing one to make sure defaults are read properly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #327 (1427f7f) into main (c85f458) will increase coverage by 2.0%.
The diff coverage is 100.0%.

❗ Current head 1427f7f differs from pull request most recent head 811cc98. Consider uploading reports for the commit 811cc98 to get more accurate results

Impacted Files Coverage Δ
src/OpenTok/OpenTok.php 91.4% <100.0%> (+0.3%) ⬆️
src/OpenTok/Session.php 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

src/OpenTok/OpenTok.php Outdated Show resolved Hide resolved
src/OpenTok/Session.php Outdated Show resolved Hide resolved
Copy link
Contributor

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rev the version (in Client.php and elsewhere) to 4.12.0?

SecondeJK and others added 2 commits February 24, 2023 11:07
Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com>
@SecondeJK
Copy link
Contributor Author

@jeffswartz I've not bumped the hardcoded version number as #328 will rewrite how this is handled (actually addresses a TODO from 2014 on dynamic user agent string handling)

src/OpenTok/OpenTok.php Outdated Show resolved Hide resolved
Copy link
Contributor

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a commit to rev the minor version.

@SecondeJK SecondeJK merged commit db655f8 into main May 9, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants