-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end-to-end encryption when creating session. #327
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rev the version (in Client.php and elsewhere) to 4.12.0?
Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com>
@jeffswartz I've not bumped the hardcoded version number as #328 will rewrite how this is handled (actually addresses a TODO from 2014 on dynamic user agent string handling) |
…P-SDK into feature/e-2-e-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a commit to rev the minor version.
…P-SDK into feature/e-2-e-support
This PR adds the end to end encryption flag when starting an OpenTok Session.
Description
See the docs for more context:
https://tokbox.com/developer/guides/end-to-end-encryption/
Motivation and Context
New features being rolled into our SDKs
How Has This Been Tested?
Added new test and modified existing one to make sure defaults are read properly.
Types of changes
Checklist: