Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom User Agent #328

Merged
merged 2 commits into from
May 10, 2023
Merged

Custom User Agent #328

merged 2 commits into from
May 10, 2023

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Feb 22, 2023

This PR adds the ability for developers to create a new Client with a custom app name, to be included in the User-Agent string.

Motivation and Context

This has been requested to be rolled out across all of the SDKs for client tracking support.

How Has This Been Tested?

Tests have been modified to pull out the original static string testing. As the string is dynamic, the new test for this is to only test the method that adds a custom app string to the Client.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SecondeJK SecondeJK changed the base branch from main to dev February 22, 2023 16:06
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #328 (c0c470d) into dev (a1e0533) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted Files Coverage Δ
src/OpenTok/OpenTok.php 91.1% <100.0%> (ø)
src/OpenTok/Util/Client.php 74.9% <100.0%> (+0.4%) ⬆️

@SecondeJK SecondeJK merged commit e83c4fc into dev May 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants