Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early frustum clipping #65

Open
vvs- opened this issue Jun 8, 2015 · 15 comments
Open

Early frustum clipping #65

vvs- opened this issue Jun 8, 2015 · 15 comments

Comments

@vvs-
Copy link
Contributor

vvs- commented Jun 8, 2015

It seems that clipping happens too early. See for example setgamef(4,6) setEntityPos(player,27242,29836,0,16,0,0), then try to rotate camera to the left. Also, try to jump straight up.

@vvs-
Copy link
Contributor Author

vvs- commented Jun 23, 2015

Could it be related to #40?

@vvs-
Copy link
Contributor Author

vvs- commented Jun 25, 2015

I have a feeling that frustum angle is determined by the Lara position and not the camera.

@stohrendorf stohrendorf added this to the TR1 milestone Jul 1, 2015
@vvs- vvs- added the Bug label Jul 13, 2015
@vvs-
Copy link
Contributor Author

vvs- commented Jul 9, 2016

Another example, but this time in TR1:
screen_00000
That yellow room above Lara should not be visible.

@vvs-
Copy link
Contributor Author

vvs- commented Jul 16, 2016

I guess it belongs here:
screen_00000

@vvs-
Copy link
Contributor Author

vvs- commented Jul 30, 2016

In Obelisk of Khamoon:
screen_00000
Happens after pulling switch 45.

@Gh0stBlade
Copy link
Member

I can't seem to reproduce this, is this still happening on the current builds?

@vvs-
Copy link
Contributor Author

vvs- commented Nov 27, 2016

I can still reproduce everything except one.

EDIT: As it turned out the last example can be reproduced on a debug optimization level.

@vvs-
Copy link
Contributor Author

vvs- commented Dec 6, 2016

When running straight from that position I've got a total blackout.
screen_00000

@vvs-
Copy link
Contributor Author

vvs- commented Dec 7, 2016

The first case described above (and many others) manifests itself where only vertical frustums exists. Even when there should be line of vision above them (i.e. horizontal frustum), actually it doesn't exist from the engine point of view. When that vertical frustum is moved out of sight, everything above it suddenly disappear, e.g. top of buildings.

@vvs-
Copy link
Contributor Author

vvs- commented Dec 7, 2016

And yet another case. Looks like it appeared only after recent changes:
screen_00000

@vvs-
Copy link
Contributor Author

vvs- commented Dec 11, 2016

Visibility problems are countless. Most times it's a wrong room in frustum. But sometimes there is nothing rendered at all: just Lara in the center of a black screen.
screen_00000

@vvs-
Copy link
Contributor Author

vvs- commented Dec 21, 2016

Another example of wrong culling of a room at the top by just moving slightly.
screen_00000
screen_00001

@vvs-
Copy link
Contributor Author

vvs- commented Jan 12, 2017

Visibility issues in TR2 are quite bad. There are instances when camera lose its room and you see a black screen. The only way to correct this is to use freelook/noclip.

@vvs-
Copy link
Contributor Author

vvs- commented Sep 7, 2017

After recent camera and overlapping rooms fixes there are still many old visibility problems present:
screen_00000

@vvs-
Copy link
Contributor Author

vvs- commented Sep 10, 2017

screen_00000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants