Allow to cross compile for Windows with Linux/Mingw (part 2 of 3, bugfixes) #1149
Conversation
|
jenkins |
| return TFxTimeRegion(tr1) += tr2; | ||
| } | ||
|
|
||
| inline DVAPI TFxTimeRegion operator+(const TFxTimeRegion &tr1, double shift) { | ||
| inline TFxTimeRegion operator+(const TFxTimeRegion &tr1, double shift) { |
There was a problem hiding this comment.
You are removing DVAPI from many parts. It seems that DVAPI is actually defined as __declspec(dllexport) in tcommon.h as follows:
145 #ifdef _WIN32
146 #define DV_EXPORT_API __declspec(dllexport)
147 #define DV_IMPORT_API __declspec(dllimport)
148 #define DV_EXPORT_VAR __declspec(dllexport)
149 #define DV_IMPORT_VAR __declspec(dllimport)
150 #else
151 #define DV_EXPORT_API
152 #define DV_IMPORT_API
153 #define DV_EXPORT_VAR
154 #define DV_IMPORT_VAR
155 #endif
Since __declspec is used only in MSVC, how about just replacing the line 145 above by #ifdef _MSC_VER instead of removing DVAPIs ?
There was a problem hiding this comment.
I've removed DVAPI for inline function only. There is no reason to use dllexport/dllimport for inline functions. Because they are inline.
|
LGTM |
see PR #1092
Fix bugs which MinGW sensitive to.