Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clean-up at the end of SceneViewer::contextMenuEvent for OSX #152

Merged
merged 2 commits into from
Apr 8, 2016

Conversation

tomosu
Copy link
Contributor

@tomosu tomosu commented Apr 8, 2016

fixed problem reported in #115 and #73 .

@kogaki
Copy link
Member

kogaki commented Apr 8, 2016

I feel this approach is a little bit confusing because view-related method contextMenuEvent clean-ups control-related members (m_mousebutton etc ...). If there's no other solutions, it is ok to merge. But here are my suggestions

  1. Cleaning-up control-realted members might be done first in the contextMenuEvent, not last
  2. Plz add some comments on the code (e.g. cleaning-up after right button click)

@tomosu
Copy link
Contributor Author

tomosu commented Apr 8, 2016

Thank you for your comment.
I reflected your suggestions to sceneViewerEvent.
Please check this.
cb0b4d0

@kogaki
Copy link
Member

kogaki commented Apr 8, 2016

LGTM

@kogaki kogaki merged commit 6f84e74 into opentoonz:master Apr 8, 2016
@xenogenesi
Copy link

I've a patch for linux which fake a release event, apparently on linux and on macosx the release event is lost handling the contextMenuEvent

@xenogenesi
Copy link

posted on #51

About #73 / #115, if someone want to give a try to this (also on mac)

@kogaki
Copy link
Member

kogaki commented Apr 11, 2016

@xenogenesi Great. Your solution looks more reasonable. Could you create the another PR so that we can test and merge smoothly ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants