Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restoring raster tool crash #2362

Merged
1 commit merged into from
Nov 5, 2018

Conversation

manongjohn
Copy link
Collaborator

This PR fixes #2361

When returning to the Raster bush from temporary usage of Hand Tool (holding tool shortcut) while still pressing with the pen, the Raster brush is no longer initialized properly so the drag event tries to work with an uninitialized tool and crashes when you try to continue moving.

Similar to Toonz Raster (where it does not crash), I modified to block the drag event from processing if not properly initialized.

@ghost
Copy link

ghost commented Nov 5, 2018

LGTM. Thanks @manongjohn

@ghost
Copy link

ghost commented Nov 5, 2018

@shun-iwasawa It's a pretty simple change. Would you like to call Jenkins on this?

@shun-iwasawa
Copy link
Member

Jenkins

@ghost ghost merged commit 5ed3624 into opentoonz:master Nov 5, 2018
@manongjohn manongjohn deleted the restore_raster_tool_crash_fix branch November 6, 2018 23:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raster level crashes when switching back to brush
2 participants