Handle more then 3 peg holes #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n resolutions. Used the same value (PERCENT * max dot size) as later in the code in compare_dots.
… fit and used that. The problem was, that the middle hole was used as center for auto center. For three peg holes that is correct, but does not work for more than three. Now the best fit is calculated and from there the offset of the middle of the three best fit holes is calculated and applied.
|
Jenkins, confirm this |
| { | ||
| int found; | ||
| int toll, i_ok = 0, j_ok = 0, k_ok = 0; | ||
| int toll; | ||
| float tolld; | ||
| int i, j, k; | ||
| short *dot_ok = 0; |
|
Thank you, I missed that. |
|
Jenkins, confirm this |
|
OK. LGTM. |
shun-iwasawa
pushed a commit
to shun-iwasawa/opentoonz
that referenced
this pull request
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support to use pegbars with more than three holes. Due to the poor availability of paper for traditional pegbars I use a puncher for a filing system with six round holes and a custom built pegbar.
The code assumed the pegbar specification to have exactly three holes. The auto center code didn't work when a peg hole was at the top border of the paper (I scanned a bit poorly) and when there are more then three holes the original code centered the page at the middle hole of the three best matching holes.
I think I could also get the code to work with only two peg holes, but have not tried yet. It might help people try out toonz (a pegbar can be easily created with a 3d-printer), but it would be also quite hard to draw and keep the pages aligned, so don't know if it is worth the try.