Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.5 Release Schedule #3597

Closed
5 tasks done
RodneyBaker opened this issue Nov 21, 2020 · 43 comments · Fixed by #3714
Closed
5 tasks done

v1.5 Release Schedule #3597

RodneyBaker opened this issue Nov 21, 2020 · 43 comments · Fixed by #3714

Comments

@RodneyBaker
Copy link
Collaborator

RodneyBaker commented Nov 21, 2020 •
edited

Revised Schedule

  • End of 2020- FEATURE FREEZE. New feature PR posted after this will not be included in v1.5
  • Two weeks for bug tracking & translation update
  • March - Release of v1.5 RC
  • Two+ weeks for urgent bug fix - releasing RC2 (as needed)
  • Release of v1.5 (Tentative date: 1 April)

Please see v1.5 Planning topic for additional/useful links: Link
@RodneyBaker RodneyBaker pinned this issue Nov 21, 2020
@RodneyBaker
Copy link
Collaborator Author

General Release Notes

@RodneyBaker

This comment has been minimized.

Sign in to view
@RodneyBaker
Copy link
Collaborator Author

RodneyBaker commented Nov 21, 2020 •
edited

This listing is a work in progress.
Please reference original reports for additional information.
(Note: There is currently some overlap with v1.4 in this listing)

Unresolved

@shun-iwasawa
Copy link
Member

Sorry for my late response and thank you @RodneyBaker for suggesting the schedule !

The time frame seems to be perfect. But I'm sorry to say that I think I need several weeks for preparing the release mainly for verifying behavior of macOS version and for porting bug fixes and some great features from Tahoma2D.

So, the schedule would be like:

  • The end of 2020- FEATURE FREEZE. New feature PR posted after this will not be included in v1.5
  • Two weeks for bug tracking & translation update
  • Late January - Release of v1.5 RC
  • Two+ weeks for urgent bug fix or releasing RC2 (if needed)
  • Mid February 2021 - Release of v1.5 (Tentative date: 15 February)

Thank you for your continued support!

@RodneyBaker

This comment has been minimized.

Sign in to view
This was referenced Dec 13, 2020
Merged
Merged
Merged
Merged
@RodneyBaker
Copy link
Collaborator Author

RodneyBaker commented Jan 8, 2021 •
edited

Opentoonz v1.5 Pre-Release notes (draft draft draft)

Animate Tool
Ease Regulations for the Use of Animate Tool

Audio
Fix - Crash on Recording Audio (Mac, Windows)

Build / Github
Custom Qt with Wintab support
New - Support for Github Actions
New - CI builds for Windows, Mac and Linux (via Github Actions)
Updated - Github Issue Templates

Brushes
New - Aotz MyPaint brush set (Sketch, Ink, Fill, Clouds, Water, Grass, Leaves, Fur, Eraser, etc.)
Fix vector custom styles

Color Model
Fix color model pick mode

Color Separation
New - Save/Reload Color Separation Colors Parameters

Control Point Editor Tool
New - Add snap option to control point editor tool
New - Freehand mode in control point editor tool

Conversion
New - Convert To Vector : Align Boundary Strokes Direction Option

Cutter Tool
New - Snap at intersection in cutter tool

Effects
New - Bloom Iwa Fx
New - Fractal Noise Iwa Fx
New - Glare Iwa Fx
New - Search bar in New Fx browser
New - Linear color space option for Add Fx Ino
New - Logarithmic option for Spiral fx
New - Particle FX Preset: Flock fx

Eraser Tool
New Segment Erase
New Frame range for segment mode of eraser tool

Expressions
New - (Optional/Experimental) Expression Reference Manager
New - Expression Function: Periodic Random
New - Copy expression object address directly from UI

Geometry Tool
New - multi arc shape in geometric tool
Fix - Geometric tool / Type tool first point offset

Image formats
Enhance - Premultiply on Loading PNG images

Keyframing
Fix - Fix copy/paste keyframe causing bad data

Level Strip
New - Horizontal Level Strip option

Monitors / Screens
Fix icon rendering for HDPI
Fix for Duplicate Window Title (Mac)
Fix for Full Screen on Multiple Monitors (WIndows)

Palette
New - (Optional) Toolbar location
New - Color Keys Global Palette

Plastic Tool
Fix - OpenGL Line Smoothing

Plugins
Updated Dwango plugins (separate download)

Rendering
Fix Batch Rendering on Mac
Updated Output Settings Dialogue

Scenes
Fix incorrect xml in tnz file

Scene Cast
Fix - Scene Cast Update on Pasting

Selector Tool
Enhancement - Improved target area for Transform selection

Style Editor
New - (Optional) Create New Style Command Button

Tape Tool
Fix - Fix Vector Tape Tool on Joining Points at the Same Position

Translation
Updated Languages ( )
New - Initial support for Norwegian Bokmal
New - Weblate widget
New - Generation of translation projects now optional in cmake

UI / Preferences
New - All New Icons (GUI Cleanup)
New - Live update for 3DLuts via Preferences
New - Additional UI Style Sheet customizations via Preferences
New - Icons for all commands
Update Default Room set

Operating Systems
New - FreeBSD support

Xsheet
New - Paste as Copy Command for XSheet
Fix - Fix Crash When Drawing on Absent Level

Shortcuts
New - More shapes for Adobe Animate keyboard shortcuts
New - Shortcut keypress length option

Undo
New - Undo: Reset Undo when Saving Levels Preference Option

... with many additional bug fixes, typo corrections, enhancements and more!

See the Opentoonz github pulse for more information: LINK

@RodneyBaker

This comment has been minimized.

Sign in to view
@shun-iwasawa
Copy link
Member

I have almost finished to setup a new Jenkins CI machine (Mac mini 2018, borrowed by courtesy of Dwango) toward the new version release.

The new build environments are as follows:
[MacOS]

[Windows]

  • Windows10 Pro (Running on VirtualBox)
  • Visual Studio Community 2019 & Visual C++ 2019
  • Qt 5.15.2
  • OpenCV 4.5.1
  • Jenkins 2.263.2

Packages deployed with the new machine are currently uploaded in my repo for trial.
Please test them and let me know if you find any critical problem.

If there seems to be no trouble, I'll replace them sometime this week.

Since the setup took longer than expected, I'm so sorry but the release schedule of V1.5 needs to be postponed until the end of February.

@RodneyBaker
Copy link
Collaborator Author

Thank you @shun-iwasawa for the update, information and for the effort put into updating the build and build systems. Thanks also to Dwango for the support in the form of fthe Mac mini!
Much appreciated.

End of February it is!

@konero
Copy link
Contributor

konero commented Feb 3, 2021 •
edited

@shun-iwasawa I've been testing your build out (Windows 10). There's a bug in QMenu alignment I think introduced in Qt 12.X or so, that messes up alignment of the items, so items that have checkable action or icon are aligned one way, text items align another. For icon and checkable items their padding box begins at the end of the checkbox or icon area.

image

One fix for this would be to apply a transparent icon to every menu item by default, but unless that can be done with some kind of apply-to-all method that would become bothersome. Then it could be fixed by reducing the left padding in the stylesheets.

opentoonz/stuff/config/qss/Default/less/layouts/mainwindow.less

Line 142 in e5926f4

padding: 3 28;

For self compiled Qt, there is supposedely a fix posted in this thread:
https://forum.qt.io/post/633114

And a bugfix seems to have been submitted here on Jan 2019: https://codereview.qt-project.org/c/qt/qtbase/+/249408/8/src/widgets/styles/qstylesheetstyle.cpp

Which doesn't seem to make sense why the bug still appears to be present in 5.15.2.

I'm not sure if switching from windows style to fusion would fix it, I don't think it's just a windows style bug.

opentoonz/toonz/sources/toonz/main.cpp

Line 597 in e5926f4

QApplication::setStyle("windows");

My knowledge is limited, I hope the fix is simple! 🤞

@manongjohn
Copy link
Collaborator

@shun-iwasawa As you built the macOS version on 10.15, it won't run on anything before that. It won't run in my 10.13 virtual environment. Granted, 10.13 is soon to be out of support if it isn't already but I think 10.14 is still in support. Is the intention that OT will only now support 10.15 and later once you move to these new build servers?

@shun-iwasawa
Copy link
Member

@konero Thank you for the notification of the bug and information. I'll try if any of the proposed measures would work.

@manongjohn Thank you for letting me know about the supporting OS version which I didn't pay attention to. I'll try the cmake variable CMAKE_OSX_DEPLOYMENT_TARGET to support older versions.

@manongjohn
Copy link
Collaborator

@shun-iwasawa Be aware, we tried CMAKE_OSX_DEPLOYMENT_TARGET when building Tahoma2D on 5.15 (I believe) but had issues due to other libraries we were using not created with backwards compatibility. So while the application might have been able to start on older systems, it would crash whenever it tried to access a library that wasn't backward compatible. Keep in mind Tahoma is self contained, unlike OT's macOS installer. I know we were having problems because some dependencies we were using were from Homebrew which isn't backwards compatible.

I'm not sure how OT's macOS installer works and what dependencies it may include/install as part of the installation process or where your dependencies are from, but thought I should warn you to be aware of this issue.

@RodneyBaker
Copy link
Collaborator Author

@shun-iwasawa I attempted to install and run the test build from your repo but cannot get it to run.
It appears to install correctly but when running it gets through the splash screen up to the point of saying 'starting main window' and then... nothing.

I haven't uninstalled Opentoonz first before running your test installer so that might be something I try next.

@shun-iwasawa
Copy link
Member

@manongjohn Thank you for the advice! As you commented, it seems to be straightforward and easier to prepare another virtual machine with previous OS than to resolve version compatibilities for all dependent libraries.. I'll try setting up one with Mojave (10.14).

@RodneyBaker Thank you for testing. I could reproduce the problem with my MobileStudioPro (non-development machine).

@shun-iwasawa shun-iwasawa mentioned this issue Feb 16, 2021
Merged
@shun-iwasawa
Copy link
Member

shun-iwasawa commented Feb 18, 2021 •
edited

I set up a new virtual machine with MacOS Mojave (10.14) to expand compatibility.
The package is in my repo replacing the older one.

@RodneyBaker I uninstalled the previous OT before installing the newer version and the problem seems to be resolved. Can you please try at your end?

@RodneyBaker
Copy link
Collaborator Author

Good news @shun-iwasawa
Your latest build works great.

I am continuing to press into the install just to see where I run into any issues but no problems encountered thus far.

@shun-iwasawa
Copy link
Member

Thank you for testing. I've stopped the old Jen.kins and made the new one to deploy to the official nightly.

@konero
Copy link
Contributor

konero commented Feb 23, 2021 •
edited

@shun-iwasawa I'm still testing your build and artifacts using Qt 5.15.2. I've noticed that if you click and drag the title of a Viewer/ComboViewer that's already docked to move it, it will turn invisible. This only happens after starting the program and trying to move an already docked Viewer/ComboViewer, it doesn't if I dock one and try move it immediately.

This system uses integrated graphics, I know there's been an issue or two with iGPU drivers and OT. The GPU is Intel HD 530. I can't test my NVIDIA cards yet, so if anybody can test in the meantime.

@RodneyBaker
Copy link
Collaborator Author

@konero I confirm the problem with the viewer turning invisible.

@konero
Copy link
Contributor

konero commented Feb 25, 2021

Jose Moreno in a message from Discord has experienced the same combo viewer issue (using an artifact listed above). I'm posting his comment here as a possible solution.

I can confirm the same bug. It only seems to affect the startup generated ComboViewer. However if you create a new comboviewer, dock it and try again it will properly drag the widget.

The most interesting thing is that if you close the program and open it again without resetting the default rooms, you will see the original comboviewer floating as if it had been dragged properly the first time.

When you open Opentoonz the second time the comboviewer will be on top of the greeting window which is weird... so a hypothesis is that the comboviewer widget could be getting redrawn below all the other widgets when you start to drag it, and since you always have to keep at least one docked widget open, it could also be that the comboviewer keeps itself in the floating state but drawn behind the main widget but since I can't verify if the viewer is drawn behind despite floating or not this is just a theory.

As a last comment to support this idea, if you keep dragging the widget without letting go, you will be able to dock it again thus restoring the widget, but if you try to drag it out once more it will "disappear".

@shun-iwasawa shun-iwasawa mentioned this issue Feb 25, 2021
Merged
@shun-iwasawa
Copy link
Member

I think I fixed the viewer issue.

Found another critical problem: OT crashes when accessing JPEG files.
I think it must be fixed before releasing RC and will look into it.

@gab3d
Copy link
Contributor

gab3d commented Feb 26, 2021

@shun-iwasawa
I just happened to suffer from this same issue (jpg crash) some minutes ago.
Thanks for checking it! 💪

@konero konero mentioned this issue Feb 26, 2021
Closed
@shun-iwasawa
Copy link
Member

I've made a new prebuilt package of Dwango Plugin Fxs which are built with the same environment as OT so that you don't need to install additional runtime like older OpenCV or Visual Studio 2013 redistributable package.

Please test them and see if it works with the current nightly build:
https://github.com/opentoonz/dwango_opentoonz_plugins/releases/tag/v1.1.0

@shun-iwasawa shun-iwasawa reopened this Mar 10, 2021
@RodneyBaker
Copy link
Collaborator Author

@shun-iwasawa I haven't had a chance to test much as of yet but a quick first look has the plugins working as expected with the latest nightly build.
I'm very excited about about the prospect of Opentoonz users having more direct access to these plugins.
I'll continue testing later tonight.

@konero
Copy link
Contributor

konero commented Mar 11, 2021

No problems from my end. 💯

@shun-iwasawa
Copy link
Member

Just released V1.5RC 🚀

@RodneyBaker
Copy link
Collaborator Author

RodneyBaker commented Mar 21, 2021 •
edited

Time for comprehensive testing folks!

Link to v1.5 Release Candidate

@shun-iwasawa
Copy link
Member

@RodneyBaker
I copied & pasted the Release Note from your draft. I'd really appreciate it if you could finalize it if there are any updates. Thanks!

@RodneyBaker
Copy link
Collaborator Author

I'll certainly give it a try.
There are quite a few additional updates.

@gab3d
Copy link
Contributor

gab3d commented Mar 24, 2021

I've just updated the What's New page in the Manual to show the v1.5 new features, enhancements and fixes.
Please check for errors/suggestions/improvements.
Thx!

@RodneyBaker
Copy link
Collaborator Author

RodneyBaker commented Mar 24, 2021 •
edited

@gab3d The Production Board was listed in the early draft and I see it in your 'What's New' listing.
That should be removed as it didn't make the cut and get into the v1.5 release.
Other than that I believe it is an accurate list.
Nice work!
I've updated the draft release notes to display as current information as possible here: #3597 (comment)

@ghost
Copy link

ghost commented Mar 24, 2021 •
edited by ghost

It seems that the locking stroke functionality with ctlr key is missing in the cutter tool and pump tool part.
And may also support the latest generations of mypaint brush (not sure).

@gab3d
Copy link
Contributor

gab3d commented Mar 25, 2021

@RodneyBaker
oh, thanks for checking it!
removed...

if there's something else to add to the list, just tell me.

@ghost
Copy link

ghost commented Apr 7, 2021

Is there an estimate on how much longer till 1.5 is released? It's past april 1st and already has had two release candidates as planned, is there anything left to do before release is go?

@gab3d
Copy link
Contributor

gab3d commented Apr 7, 2021

probably not much longer... why the rush?

its the very essence of RCs that they are out for people to have the chance to try them and report show-stopper bugs, and when they do, it's sensible to allow the time for them to be fixed...

@RodneyBaker
Copy link
Collaborator Author

Just a note to say that according to the feedback I am seeing the updated RC2 is resolving most of users recently reported problems (esp. as relates to RC1).

@shun-iwasawa
Copy link
Member

I just released V1.5. Thank you very much for all the contributions for releasing the new version so far!

@F-Burning
Copy link

Thank you very much for your constant work and dedication 👏

@ghost
Copy link

ghost commented Apr 10, 2021

Awesome. Glad to see the update went smoothly. @shun-iwasawa I was told by @RodneyBaker that you're the one I should talk to about getting libtiff dependency straightened out. The packaged dependency that comes with OpenToonz needs to be replaced with the system libtiff. Now that 1.5 has been released, work on that can get started. How do you propose we fix this?

@gab3d
Copy link
Contributor

gab3d commented Apr 10, 2021

Congrats @shun-iwasawa @RodneyBaker and every other developer and interested people that has contributed his/her time and efforts for the improvement of the project!! 😃 💪
Go! Go! Go!

@RodneyBaker
Copy link
Collaborator Author

RodneyBaker commented Apr 10, 2021 •
edited

Congratulations everyone!
Thanks to all the hard work of all contributors. There are a lot of updates in this release.

Thank you @shun-iwasawa for your hard work and patience and for the behind the scenes updates that make everything work.
As much as is apparent on the surface of this release there is even more that will carry Opentoonz forward in ways that weren't possible before. Much appreciated!

The work is over... let the work now begin. :)

@jointri I believe you already have a report/issue open on the libtiff update. I'll recommend continuing the discussion there.

@RodneyBaker RodneyBaker unpinned this issue Apr 12, 2021
@Al532 Al532 mentioned this issue Apr 20, 2021
Open
@RodneyBaker
Copy link
Collaborator Author

Forgot to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Icons for all commands shun-iwasawa/opentoonz
6 participants
@RodneyBaker @shun-iwasawa @gab3d @manongjohn @konero @F-Burning