Use "X" and "Y" instead of "E/W" and "N/S". Closes #3337.

[morevnaproject]

Closes #3337.

[RodneyBaker]

Correct me if I am wrong but this is more a cosmetic change right?
Expressions still need to refer to the old east/west and north/south terms (ex: col1.ew and not col1.x).

[morevnaproject]

Yes, this is cosmetic change.

I think we shouldn't change expressions, as this make old scripts incompatible.

Actually, it would be nice to make modification so OT will understand both col1.ew and col1.x, but I would like to know what people think about this idea.

[RodneyBaker]

Actually, it would be nice to make modification so OT will understand both col1.ew and col1.x, but I would like to know what people think about this idea.

That would be nice.
I agree that changing the underlying expressions would be a breaking change not welcome by many older users and this would also break compatibility with Toonz and other older products.

Aside:
Perhaps one step more would be to give channels a 'title' that can be changed.
Then that title could be used in the expression (or the underlying object that is there currently).
Then long expressions could be shortened by referencing the title.
The 'title' could be 'col1.x', or 'BG.pan' but the object would remain 'col1.ew'
Yes, I agree this would be a complex undertaking.
Thus I'm not suggesting it be implemented... just taking the idea to a logical conclusion that allows for maximum customization and flexibility.

`

[gab3d]

@morevnaproject
I strongly agree with all the scope of your proposal (both cosmetic and functional).
Of course compatibility must be preserved.

In fact I have changed E/W and N/S in favor of X and Y in the Spanish version of the UI since the very begining of the translation, as most people tend to be more familiar with the X and Y notation.

[shun-iwasawa]

It's fine with us to change the terms "E/W" and "N/S" to "X" and "Y".
And as @RodneyBaker pointed, the expression should also be modified at the same time.

Actually, it would be nice to make modification so OT will understand both col1.ew and col1.x,

You can add x and y to the expressions by modifying the code of txsheetexpr.cpp as follows:

   TStageObject::Channel matchChannelName(const Token &token) const {
     std::string s = toLower(token.getText());
-    if (s == "ns")
+    if (s == "y" || s == "ns")
       return TStageObject::T_Y;
-    else if (s == "ew")
+    else if (s == "x" || s == "ew")
       return TStageObject::T_X;
     else if (s == "rot" || s == "ang" || s == "angle")
       return TStageObject::T_Angle;

[morevnaproject]

You can add x and y to the expressions by modifying the code of txsheetexpr.cpp as follows:

Thank you! Will do that. ^__^

[manongjohn]

FYI... Put "Closes #3337" in the PR description so it will close that PR automatically when merged. I don't think it does that from the PR's title.

[morevnaproject]

I have done all changes. Please review. ^__^

[shun-iwasawa]

Sorry for the many comments, but I marked all points I could found.

Note that you also need to lrelease the translation file (i.e. making.qm files from updated .ts files and overwriting the old ones in stuff/config/loc/) to actually update the translated UI texts in the software. Please let me know if it's unfamiliar to you.

[RodneyBaker]

As the suggested changes at this point all relate to translations perhaps someone on the translation team can give this PR an assist.

[morevnaproject]

@RodneyBaker Thank you for reminder! I am going to make fixes now. ^__^

[morevnaproject]

Done! ^__^

[morevnaproject]

Note that you also need to lrelease the translation file (i.e. making.qm files from updated .ts files and overwriting the old ones in stuff/config/loc/) to actually update the translated UI texts in the software. Please let me know if it's unfamiliar to you.

Yes, I am not sure how to do that properly. I am aware on how to run lrelease to generate .qm files one-by-one. But maybe there is some script to update all qm files automatically?

[shun-iwasawa]

Jenkins

[shun-iwasawa]

Sorry for the long silence! Thank you @morevnaproject for the modification.
Releasing .qm files can be done in the future in separate PR, probably together with updating translations of other terms.
LGTM