CMake: Conditionally add warnings when supported #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds utility functions to conditionally add compiler flags, allowing warnings from newer compiler versions to be used without causing a lot of noise for users of older compilers.
|
Jenkins, test this. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds utility functions to conditionally add compiler flags (when they're supported by the compiler),
allowing warnings from newer compiler versions to be used without
causing a lot of noise for users of older compilers.
Using
C/CXX_WARNINGSalso makes it easier to configure warnings based on different compilers instead of platforms, Clang/GCC on OSX and Linux can use the same warnings for example.