WIP - Linked styles enabled and style right click menu organized

[ghost]

• Re-enabled linked styles - "Toggle Link to Studio Palette"
• Changed "Remove Links" to "Remove Reference to Studio Palette"
  • This sounds wordy, but it was to avoid confusion about toggling the link
• Re-enabled "Delete Unused Styles"
• Made toggle link and remove connection able to have shortcuts (Default for toggle link is )

To update linked colors, save the Studio Palette and now the option to update linked styles works.

[konero]

Nice.

Edit: Disregard.

[ghost]

@konero - I understand your point there. The reason I chose the word connection was to prevent users from mistaking it from simply disabling the link temporarily. Once you remove the connection, there is no way to get it back ( I think ), so I wanted it to be clear that all interaction between the level style and the studio style would be severed with that option. The original code that I uncommented out used the term "Remove Reference to Studio Palette". I am not too attached to the term, so if it seems that people prefer "Remove link" I don't mind changing it.

[konero]

I was wrong, it's not link in TP. I had a look back through the Harlequin manual, its called "Remove Reference to Studio Palette" and they call that little white square the "studio palette reference icon". So if remove is used it would remove the white square, when toggle is used it toggles the icon between blank and an arrow. In that case reference would make more sense, considering its what you'll find in documentation and Toonz Premium.

Remove Reference to Studio Palette

[ghost]

@konero I think it is a valid point that keeping the documentation between the two in sync could be useful. However, the point could be made that each new feature that is added to OT makes the old documentation less accurate anyway. I think that the wording should be the least confusing for end users. I personally think that the term "connection" makes more immediate sense than "reference," but again that's only my opinion. I would like to hear from others regarding the phrasing. I will put whatever seems to be the consensus.

[blurymind]

I agree with @turtleTooth that connection sounds a little bit more obvious :)

[blurymind]

I think you should review and merge it and then get feedback from the entire user community - as they will then try it in the nightly

[AyameLee]

If you're going to change it to Connection you might as well use a shorter synonym like Link, since that menu looks wide.

How does this feature work exactly? Since I haven't used it, then it is difficult to gauge. The way I would personally utilize this is by using the Studio Palette to pick and hold all colors which Levels "refer" to, meaning they can't overwrite the Studio Palette. In that case Reference is a better term like a color model. Link or Connection would state either palette file can overwrite the other, which just seems wrong to me, but that may indeed be how it works.

[RodneyBaker]

You could always be bold and use 'Ref'. :)

Reference does seem a bit more technically correct.
This especially in light of other things that use the same term.

On Fri, Jul 15, 2016 at 11:13 AM, AyameLee notifications@github.com wrote:

If you're going to change it to Connection you might as well use a
shorter synonym like Link, since that menu looks wide.

How does this feature work exactly? Since I haven't used it, then it is
difficult to gauge. The way I would personally utilize this is by using the
Studio Palette to pick and hold all colors which Levels "refer" to, meaning
they can't overwrite the Studio Palette. In that case, Reference is a
better term, like a color model.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#628 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACdQMCo0c5Pu7weMR8HWPWX_yZ_fqV_uks5qV7GfgaJpZM4JKCAA
.

[blurymind]

i think shortening the names too much will make them vague

On Fri, Jul 15, 2016 at 8:31 PM, RodneyBaker notifications@github.com
wrote:

You could always be bold and use 'Ref'. :)

Reference does seem a bit more technically correct.
This especially in light of other things that use the same term.

On Fri, Jul 15, 2016 at 11:13 AM, AyameLee notifications@github.com
wrote:

If you're going to change it to Connection you might as well use a
shorter synonym like Link, since that menu looks wide.

How does this feature work exactly? Since I haven't used it, then it is
difficult to gauge. The way I would personally utilize this is by using
the
Studio Palette to pick and hold all colors which Levels "refer" to,
meaning
they can't overwrite the Studio Palette. In that case, Reference is a
better term, like a color model.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#628 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ACdQMCo0c5Pu7weMR8HWPWX_yZ_fqV_uks5qV7GfgaJpZM4JKCAA

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#628 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGMbVab6TFNi2VYIWD0CMKsZuXqc_zTOks5qV9_-gaJpZM4JKCAA
.

[ghost]

I'm going to change it back to reference. I don't think link is best because I think there should be a clear distinction between temporarily turning on and off the connection to the Studio Palette (Toggle Link) and permanently removing the connection - (Remove Reference). @AyameLee You are right that it is a one way street- the layer palette cannot push to the studio palette.

[ghost]

BTW- I am going to put this in tonight's portable version for anyone who wants to try it on Windows.

[blurymind]

Cant wait to try it :)

[blurymind]

@turtleTooth can we make it a two way street? Having the level palette push back changes to the studio palette when link is enabled would be more intuitive.

Then saving the changes to the studio palette would still be all that it takes to propagate them to the other levels

[blurymind]

This coul be optional :) but its an idea

[blurymind]

@AyameLee the goal of the linking feature is to setup global colors that can easily be shared by multiple levels. Without it dealing with color consistency across levels is a laborious task on opentoonz

[ghost]

@blurymind That would be nice. Could you make an issue for it? It should probably be its own PR and I won't be able to get to it super soon.

[ghost]

Connection has been changed to Reference

[ghost]

Windows users can test this here: https://github.com/turtletooth/OpenToonzPortable/releases/tag/1.0.3-FeatureTest

[Rayek]

Just tested it - it works like a charm. Thank you, it indeed simplifies palette management tremendously.

[AyameLee]

@blurymind It doesn't make sense to push changes to the Studio Palette, why would you use it this way?

You should only want to read from a master file once production has begun. It works the same way with Harmony, FlipBook and Retas. You can either link to the master palette or import a unique copy. The link method must never allow the master file to be overwritten.

Imagine you were doing some oil painting and you decided to change your Cadmium Yellow to a Cadmium Orange, but instead of just changing the color on your palette, instead every oil painting you've ever painted has changed color where Cadmium Yellow was used.

[blurymind]

@AyameLee You dont even use the feature , so how can you understand its value :D

You still would need to have palette editing unlocked.
You still would need to have enabled linking.
You still would need to save the studio palette in order to apply the change.
How many more safeguards do you want?

[blurymind]

That said - perhaps there should be a * symbol or some kind of a hint on styles on the studio palette that have been changed since they were saved - this would warn the user that hitting the save button would write a new value to the style - but wasnt there already a warning on changed styles?

[blurymind]

@Rayek how did you get the linking to work? I seem to have trouble enabling it. When I enable it no arrow indicator appears - and the functionality is not there

[blurymind]

Now it started working - the first time it didnt. I will find out why

[blurymind]

@turtleTooth It doesnt initially work if you 'load into current palette'

Ok here are the steps to reproduce the problem:

1. create a new level by drawing with the brush on the empty canvas
2. select a studio palette and 'load into current palette'
3. right click on a level style and 'toggle link to studio palette'

nothing will happen

1. save studio palette's change and try again - nothing
2. right click on studio palette and this time do 'merge to current palette' - a new page will apear with the styles

toggling link still doesnt work on them either
nor does get color from studio palette

[blurymind]

I dont understand why its not working - removing reference doesnt seem to do anything either.

Yet I did something to get it to work. What am I missing

[blurymind]

Linking doesnt work - its still very broken.

[blurymind]

I will write down if i manage to figure out how I got linking to work once.

In harlequin you just
load a studio palette to the current level palette (load into current palette) and enable it (toggle link..). Thats it.

here it doesnt work at all

[blurymind]

Here it is still Broken in Opentoonz:

and here it is functioning in Toonz Harlequin:

[ghost]

I will look into it. For now does it work if you drag the palette into the
level palette?

On Jul 16, 2016 8:58 AM, "Todor Imreorov" notifications@github.com wrote:

Here it is still Broken in Opentoonz:
[image: brokenlinking]
https://cloud.githubusercontent.com/assets/6495061/16895428/a49e07e2-4b6d-11e6-9498-13082e1e1d8c.gif

and here it is functioning in Toonz Harlequin:
[image: linkingworking]
https://cloud.githubusercontent.com/assets/6495061/16895443/168b590e-4b6e-11e6-8002-232d09d43ef4.gif

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#628 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEXUfS17tMFisIvvRCBfe-mRLEv-C7fcks5qWPGGgaJpZM4JKCAA
.

[blurymind]

@turtleTooth When you drag and drop it - linking does work.

So something must be broken/missing with the right click commands to:
'load into current palette' and 'merge to current palette' - when using them - it is not possible to toggle the link.

[blurymind]

Another problem I found:

When using a linked style - the strip thumbnail of the frame fails to update to changes made on it.

[ghost]

@blurymind Thank you for finding the other bugs. It looks like this is a much bigger rabbit hole than I expected.

[ghost]

I'm closing this until I can submit a more complete PR. I didn't realize the variety of ways there were to break linked styles.

[blurymind]

Thats understandable. I hope you dont give up on it. The feature is definitely a must have imo.
It's hard to imagine why dwango would remove it in the first place. How removing it would cause all of these regressions.

[ghost]

I haven't given up on it. I just didn't realize the depth of the issue when I submitted. Right now, there are a few more pressing PR I want to make before the school year starts so my kids have the best interface.

[blurymind]

without this - coloring would be difficult and time consuming - especially for cut out style

[ghost]

I haven't forgotten about this. There are just a few other things I'm going
to try and get to before my students start using it this year. Right now
the palette file gets really dirty when importing more than one studio
palette or deleting a palette and reimporting it. Would you mind using a
toonz raster level and linking and unlinking a bunch of studio palettes and
sharing the file or telling me what happens?

The current setup gets multiple copies of the same palette on the file and
i think OT gets confused.

Without knowing the actual desired behavior, it's hard to implement it.

On Jul 29, 2016 4:58 PM, "Todor Imreorov" notifications@github.com wrote:

without this - coloring would be difficult - especially for cut out style

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#628 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEXUfafNrSmYzdAO-sQtPdTJAl-DH-zRks5qaoWLgaJpZM4JKCAA
.