Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Apache 2 license #11

Merged
merged 1 commit into from
Aug 13, 2020
Merged

add Apache 2 license #11

merged 1 commit into from
Aug 13, 2020

Conversation

dholbach
Copy link
Contributor

@dholbach dholbach commented Feb 24, 2020 •
edited
Loading

closes: #3

@dholbach dholbach requested a review from rnburn February 24, 2020 06:54
@dholbach
Copy link
Contributor Author

dholbach commented Mar 6, 2020

Who else needs to review and 👍 this?

@tamalsaha
Copy link

Can this pr be merged? We would also like to see a LICNESE for this repo.

@dholbach
Copy link
Contributor Author

@fho @bboreham @mmoustai Pinging all contributors I can see on https://github.com/opentracing-contrib/go-grpc/graphs/contributors.

@fho
Copy link
Contributor

fho commented Mar 24, 2020

Fine for me 👍

@sidh
Copy link

sidh commented Mar 30, 2020 •
edited
Loading

@fho @bboreham @mmoustai Pinging all contributors I can see on https://github.com/opentracing-contrib/go-grpc/graphs/contributors.

This blocks us from using this repo. :(

So yeah, would very much like the addition of a license. @bboreham @mmoustai

@bboreham
Copy link
Contributor

SGTM.

@dholbach
Copy link
Contributor Author

According to #3 we still need 👍 from @kcamenzind @bhs @hzariv?

@sidh
Copy link

sidh commented May 28, 2020

Any news on this?

bhs
bhs approved these changes May 28, 2020
View reviewed changes
Copy link

@bhs bhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(in case this was blocking progress – sorry I missed it!)

@sidh
Copy link

sidh commented Jun 4, 2020

Awesome! Just two more please! @kcamenzind @hzariv

@sidh
Copy link

sidh commented Jun 10, 2020

Aaaaand one more! @kcamenzind

@dholbach
Copy link
Contributor Author

Looks like this can be merged now, right?

@sidh
Copy link

sidh commented Jun 16, 2020

Looks like this can be merged now, right?

Looks like it.

@sidh
Copy link

sidh commented Jun 18, 2020

Need someone with write access to merge it. @austinlparker may be?

@sidh
Copy link

sidh commented Jul 1, 2020

Can anyone merge it?

@sidh
Copy link

sidh commented Jul 21, 2020

Anyone with write access? @fho @bboreham @rnburn @mmoustai @austinlparker

Sorry for pinging everyone :|

@sidh
Copy link

sidh commented Aug 13, 2020

Anyone? @fho @bboreham @rnburn @mmoustai @austinlparker

@austinlparker austinlparker merged commit 4a6760c into opentracing-contrib:master Aug 13, 2020
@austinlparker
Copy link
Member

sorry for the delay!

@dholbach dholbach deleted the apache2-license branch August 13, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnburn rnburn rnburn approved these changes

@bhs bhs bhs approved these changes

@hzariv hzariv hzariv approved these changes

@kcamenzind kcamenzind kcamenzind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License missing
10 participants
@dholbach @tamalsaha @fho @sidh @bboreham @austinlparker @rnburn @bhs @hzariv @kcamenzind