Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interceptors can take multiple different decorators #44

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Interceptors can take multiple different decorators #44

merged 1 commit into from
Sep 9, 2019

Conversation

ravirajj
Copy link
Contributor

@ravirajj ravirajj commented Sep 7, 2019 •
edited
Loading

  • Enable not just one but multiple different decorators to update the Span.

@coveralls
Copy link

coveralls commented Sep 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 158

  • 59 of 60 (98.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.7%) to 95.843%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/opentracing/contrib/grpc/ClientTracingInterceptor.java 30 31 96.77%
Totals Coverage Status
Change from base Build 156: 1.7%
Covered Lines: 415
Relevant Lines: 433
💛 - Coveralls

@ravirajj ravirajj changed the title Interceptors take client/server span/close decorator lists Interceptors can take multiple different decorators Sep 8, 2019
@malafeev malafeev merged commit 87a993e into opentracing-contrib:master Sep 9, 2019
@ravirajj ravirajj deleted the rj.decorators branch September 9, 2019 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malafeev malafeev malafeev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravirajj @coveralls @malafeev