Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Oracle oci driver causes NPE, because of OracleURLParser "thin" expectations #71

Closed
ivan-slavchev opened this issue Mar 13, 2020 · 3 comments
Closed

Using Oracle oci driver causes NPE, because of OracleURLParser "thin" expectations #71

ivan-slavchev opened this issue Mar 13, 2020 · 3 comments

Comments

@ivan-slavchev
Copy link
Contributor

When using "oci" driver instead of "thin" the OracleURLParser is not capable of recognizing the pattern and returns null. This causes NPE later. At the same time the prefix that is expected for the OracleURLParser to pick up the connection string is "jdbc:oracle" and not "jdbc:oracle:thin". This makes it impossible to register custom parser specifically for oci.
@malafeev
Copy link
Contributor

@ivan-slavchev would you like to submit PR?

ivan-slavchev added a commit to ivan-slavchev/java-jdbc that referenced this issue Mar 16, 2020
@ivan-slavchev
opentracing-contrib#71 added basic support for oci driver in OracleUR…
624b3ae 
…LParser
@ivan-slavchev
Copy link
Contributor Author

#72

malafeev pushed a commit that referenced this issue Mar 16, 2020
@ivan-slavchev
#71 added basic support for oci driver in OracleURLParser (#72)
7b1a52e
@malafeev
Copy link
Contributor

0.2.10 release with fix will be available in couple of hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malafeev @ivan-slavchev