Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parsing H2 URL with implicit file mode #34

Merged
merged 2 commits into from
May 7, 2019
Merged

fix parsing H2 URL with implicit file mode #34

merged 2 commits into from
May 7, 2019

Conversation

malafeev
Copy link
Contributor

@malafeev malafeev commented May 6, 2019

fix for #33

@malafeev
#33 fix parsing H2 URL with implicit file mode
5e8eac2 
Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
@malafeev
skip tcp mode
dedcb08 
Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 130

  • 13 of 14 (92.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 44.329%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/opentracing/contrib/jdbc/parser/H2URLParser.java 12 13 92.31%
Totals Coverage Status
Change from base Build 120: 0.7%
Covered Lines: 383
Relevant Lines: 864
💛 - Coveralls

@malafeev malafeev merged commit bf01dbe into master May 7, 2019
@malafeev malafeev mentioned this pull request May 7, 2019
Closed
@malafeev malafeev deleted the implicit_h2_file_mode branch May 7, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malafeev @coveralls