Porting Spring Sleuth implementation of @KafkaListener support
#83
Conversation
| @@ -26,7 +26,6 @@ | |||
|
|
|||
| @KafkaListener(topics = "spring") | |||
| public void listen(String message) { | |||
| // TODO: no active span | |||
| System.out.println("active span: " + tracer.activeSpan()); | |||
There was a problem hiding this comment.
@orange-buffalo could you add a check that active span is not null here anymore?
There was a problem hiding this comment.
Sure, added an assertion.
| */ | ||
| package io.opentracing.contrib.kafka.spring; | ||
|
|
||
| import io.opentracing.*; |
There was a problem hiding this comment.
please don't use .* in imports
There was a problem hiding this comment.
Alright. It would be helpful for the contributors if project owners integrated a checkstyle or similar tool into the build, if some code convention rules are important to them.
| import org.springframework.kafka.core.DefaultKafkaProducerFactory; | ||
| import org.springframework.kafka.core.KafkaTemplate; | ||
| import org.springframework.kafka.core.ProducerFactory; | ||
| import org.springframework.kafka.core.*; |
There was a problem hiding this comment.
please don't use .* in imports
| } | ||
|
|
||
| @Pointcut("execution(public * org.springframework.kafka.config.KafkaListenerContainerFactory.createListenerContainer(..))") | ||
| private void anyCreateListenerContainer() { |
There was a problem hiding this comment.
why we need it if it doesn't do anything?
There was a problem hiding this comment.
Not sure what you mean, it is used by @Around aspect. Defining a pointcut is a canonical Spring AOP way to introduce aspects.
Pull Request Test Coverage Report for Build 250
💛 - Coveralls |
…kaListener` support
A fix for #26.