Add @Traced annotation #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentation and move shared logic from @Scheduled/@Traced to a base class
ledor473
changed the title
|
Any timeline when this feature will be available? I was looking to build something like this, if it is available it will help a lot |
Closed
|
LGTM, @pavolloffay WDYT? |
|
The feature looks reasonable, I haven't gone through the code though |
|
Thanks a lot for this work @ledor473! Remind me to do a release next week please :) |
|
Thanks @geoand! I've added a reminder for the release next week. |
|
@geoand ping |
|
I launched the release process for 0.6.0
…On Thu, Jan 21, 2021 at 5:17 PM Louis-Etienne ***@***.***> wrote:
@geoand <https://github.com/geoand> ping
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#302 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBMDP5ITX4VRXGTPJEJUCDS3BAOZANCNFSM4RUXETSA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily based on #184 but I removed the MDC bits.
Hopefully this fixes #98
Changes:
Add
@Tracedannotation plusMethodInterceptorSpanDecoratorwith a standard implementation and move shared logic from@Scheduled/@Tracedto a base class