V1.0.0 #5
Merged
V1.0.0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Integration with OT 2.0.
Do not use store our own objects to Tornado objects if that's not really needed, and use partial functions instead.
And rename related items (opentracing_tracer and similar ones). Having it with the Tracer suffix made users think this was an actual opentracing.Tracer, which is not the case.
Replace the more basic functools, as we are anyway using wrapt already in part of our code base.
It was not being automatically restored (in contrast to how it *is* for incoming request's callbacks), so fix that, and make our tests reproduce such scenario.
The reasons are: 1. It's common to issue many requests at once, and that is not supported, as part of TornadoScopeManager, as the used StackContext gets messed up. This would greatly limit our instrumentation code. 2. Issuing requests is the last part of the pipeline, so no further children Spans could consume it. Nevertheless, we provide it in the start_span callback.
'error' needs to be a boolean, and 'error.object' is a log entry, not a tag.
Use standard tags from opentracing and tune the error logs as well.
1. trace_all=True, trace_client=True when using global patching. 2. trace_all=False, trace_client=False when doing explicit decoration.
Simply do not trace anything in such case.
This is in case the start_span_cb was previously set directly on the TornadoTracing object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.