Fix minor documentation comment issues #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwe1ss
approved these changes
Jan 27, 2019
MikeGoldsmith
approved these changes
Jan 28, 2019
|
Yup, looks good with me too. Thanks @gregkalapos! |
|
Thx @cwe1ss @MikeGoldsmith! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened the repo with JetBrains Rider and it marked a couple of things in documentation comments with error.
Mainly 2 things:
MockSpan.cswithoutusingI think based on the specs those are correct and VS has no problem with it, still with this PR 1) Rider shows no errors anymore and 2) I see that the docs almost always use generic parameters, except in the cases this PR fixes, so this'd add consistency.