This repository has been archived by the owner on May 23, 2023. It is now read-only.
Fixes #145 - Rename package in opentracing-noop to io.opentracing.noop #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
|
@bhs Just sending requested notification. |
|
@kratz74 thank you. The good news is that this is an improvement. The bad news is that it's a breaking change. Since @pavolloffay offered to think of alternative solutions on #145 I would like to wait for him to offer an opinion before merging. Since we're about to do a 1.0 for OT-Java, my sense is that we should probably merge this since it'll just be more painful to do later. |
|
Based on the discussion with @judovana, It seems that this is the best solution to this. |
|
@pavolloffay thanks. I guess we ought to merge, then? Not sure what reasonable alternative we have. |
|
(I'll give it 24h) |
|
⏰ went off... merged. Thanks @kratz74! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomas Kraus tomas.kraus@oracle.com