Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Tests failing with Tornado 6.x version due to missing stack_context #115

Closed
toabctl opened this issue Mar 9, 2019 · 6 comments
Closed

Comments

@toabctl
Copy link

toabctl commented Mar 9, 2019

Tornado removed the stack_context module (see tornadoweb/tornado@45d9f6d ) so current test runs are failing with:

==================================== ERRORS ====================================
____________ ERROR collecting tests/scope_managers/test_tornado.py _____________
tests/scope_managers/test_tornado.py:27: in <module>
    from opentracing.scope_managers.tornado import TornadoScopeManager
opentracing/scope_managers/tornado.py:24: in <module>
    import tornado.stack_context
E   ModuleNotFoundError: No module named 'tornado.stack_context'
===================== 104 passed, 1 error in 0.89 seconds ======================
make: *** [test] Error 1
The command "make test testbed lint" exited with 2.
@yurishkuro
Copy link
Member

Tornado 6.x dropped support for Python 2.x altogether (tornadoweb/tornado#2443).

toabctl added a commit to toabctl/opentracing-python that referenced this issue Mar 11, 2019
tornado >= 6 dropped support for python2 (see [1]) so pin to a lower
version for now.

Fixes opentracing#115

[1] tornadoweb/tornado#2443
@condorcet
Copy link
Contributor

I think there is no reason to support TornadoScopeManager for Tornado>=6, because we can use AsyncioScopeManager instead. Here is proof of concept of the way how we can support new Tornado #118

@Jamim
Copy link
Contributor

Jamim commented Apr 30, 2019

Probably, this ticket can be closed since #121 fixes the issue as far as I can see.

@yurishkuro
Copy link
Member

#121 pins `'tornado<6', so not exactly the solution to this issue.

@yurishkuro yurishkuro changed the title Tests failing with newer tornado version due to missing stack_context Tests failing with Tornado 6.x version due to missing stack_context May 1, 2019
@vissssa
Copy link

vissssa commented Dec 30, 2019

Should remind ’tornado<6,>=4.1‘

@yurishkuro
Copy link
Member

we're already testing with tornado >= 6, and all tests are green in master, so I don't think this is an issue any longer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants