This repository has been archived by the owner on May 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 161
Tests failing with Tornado 6.x version due to missing stack_context
#115
Comments
Closed
Tornado 6.x dropped support for Python 2.x altogether (tornadoweb/tornado#2443). |
toabctl
added a commit
to toabctl/opentracing-python
that referenced
this issue
Mar 11, 2019
tornado >= 6 dropped support for python2 (see [1]) so pin to a lower version for now. Fixes opentracing#115 [1] tornadoweb/tornado#2443
I think there is no reason to support |
Probably, this ticket can be closed since #121 fixes the issue as far as I can see. |
#121 pins `'tornado<6', so not exactly the solution to this issue. |
stack_context
stack_context
Should remind ’tornado<6,>=4.1‘ |
we're already testing with |
This was referenced Oct 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Tornado removed the
stack_context
module (see tornadoweb/tornado@45d9f6d ) so current test runs are failing with:The text was updated successfully, but these errors were encountered: