Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Drop support for Python 2 #2443

Merged
merged 28 commits into from
Jul 14, 2018
Merged

*: Drop support for Python 2 #2443

merged 28 commits into from
Jul 14, 2018

Conversation

bdarnell
Copy link
Member

Kick off 6.0 by deleting everything that is now obsolete:

  • Non-asyncio IOLoop and Future implementations
  • Callback arguments
  • stack_context
  • WSGIAdapter
  • Legacy gen interfaces
  • Tests that use exec to work around the absence of async keywords in py2
  • Lots of conditional imports and other mixed 2/3 hackery

Net result: total line count of the repo (including docs, etc. Measured with git ls-files | xargs wc) drops from 57037 to 48829, a reduction of 8208 lines or almost 15%.

@bdarnell
Set version number to 6.0.dev1
38c0cef
@bdarnell
build: Stop building and testing with python 2.7 and 3.4
fa6a7ff 
Also temporarily remove nightly from the list, because travis's
"nightly" on trusty is pinned to an alpha of 3.7 with some slightly
different behaviors (testing on 3.7 is covered by appveyor)
@bdarnell
ioloop: Delete PollIOLoop
d4baaa3 
This was py2-only and is no longer used.
@bdarnell
concurrent: Delete legacy Future implementation
354d8c0
@bdarnell
gen: Delete legacy YieldPoint interfaces
38166b8
@bdarnell
auth: Remove deprecated callback interfaces
71ffeed
@bdarnell
concurrent: Delete return_future and other deprecated interfaces
0926702
@bdarnell
escape: Remove (some) python 2 compatibility
e5a8f84
@bdarnell
gen: Remove coroutine callback args and other py2 support
71601f7
@bdarnell
web,http1connection: Remove callback argument to flush()
1d1d02f
@bdarnell
httpclient: Remove callback argument and deprecated error behavior
d736f93
@bdarnell
httputil: Remove deprecated interfaces
99b1e2b
@bdarnell
ioloop: Remove remaining deprecated interfaces
fcbd402
@bdarnell
iostream: Remove deprecated interfaces
a55c7fe 
This is the riskiest change in this series since it does some internal
refactoring to get rid of some callback-related machinery.
@bdarnell
locale,netutil,process: Minor deprecation/py3 updates
e575d7b
@bdarnell
testing: Simplify imports for python 3
40c33fd
@bdarnell
util: py3 cleanups
5bc486e
@bdarnell
maint: Delete appengine test scripts
70ab73b
@bdarnell
twisted: Delete TwistedReactor and its tests
004de9c
@bdarnell
twisted: Dust off the twisted web compatibility tests
30c86e7
@bdarnell
wsgi: Remove WSGIAdapter/WSGIApplication
70adb34
@bdarnell
web: Delete asynchronous decorator
920ce30
@bdarnell
stack_context: Delete the whole module
45d9f6d
@bdarnell
docs: Doc and lint updates
432473e 
Just enough to unbreak the build for now.
@bdarnell
test: Clean up unnecessary skips and conditionals
fd17f53
@bdarnell
*: Remove unnecessary conditional imports
e1d24ac
@bdarnell
test: Remove legacy unittest2 compatibility cruft
6fc9998
@bdarnell
*: Remove Python2 __future__ imports throughout the codebase
e332a7d
@bdarnell bdarnell merged commit f6e98e2 into tornadoweb:master Jul 14, 2018
@bdarnell bdarnell deleted the drop-py2 branch July 14, 2018 21:21
@kinow kinow mentioned this pull request Sep 6, 2018
Closed
6 tasks
@ploxiln ploxiln mentioned this pull request Sep 15, 2018
Closed
@yurishkuro yurishkuro mentioned this pull request Mar 11, 2019
Closed
toabctl added a commit to toabctl/opentracing-python that referenced this pull request Mar 11, 2019
@toabctl
setup.py: Pin tornado to version < 6
6320b6b 
tornado >= 6 dropped support for python2 (see [1]) so pin to a lower
version for now.

Fixes opentracing#115

[1] tornadoweb/tornado#2443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bdarnell