Skip to content

Commit

Permalink
demote repeated add warnings to trace level because there are so many
Browse files Browse the repository at this point in the history
1. repeated adds are usually due repeated series of nodes on OSM ways
2. edges currently use semantic rather than identity equality, so this
does not distinguish GB errors from genuine double edges in input
3. edge lists may eventually be replaced with CopyOnWriteArraySet<E>
  • Loading branch information
abyrd committed Apr 5, 2012
1 parent 2cfd230 commit 6cb9c01
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public int hashCode() {
@Override
public void addOutgoing(Edge ee) {
if (outgoing.contains(ee)) {
LOG.error("repeatedly added edge {} to vertex {}", ee, this);
LOG.trace("repeatedly added edge {} to vertex {}", ee, this);
}
outgoing.add(ee);
}
Expand All @@ -142,7 +142,7 @@ public synchronized void addOutgoingConcurrent(Edge ee) { // create TemporaryEdg
public void removeOutgoing(Edge ee) {
outgoing.remove(ee);
if (outgoing.contains(ee)) {
LOG.error("edge {} still in edgelist of {} after removed. there must have been multiple copies.");
LOG.trace("edge {} still in edgelist of {} after removed. there must have been multiple copies.");
}
}

Expand All @@ -162,7 +162,7 @@ public Collection<Edge> getOutgoing() {
@Override
public void addIncoming(Edge ee) {
if (incoming.contains(ee)) {
LOG.error("repeatedly added edge {} to vertex {}", ee, this);
LOG.trace("repeatedly added edge {} to vertex {}", ee, this);
}
incoming.add(ee);
}
Expand All @@ -178,7 +178,7 @@ public synchronized void addIncomingConcurrent(Edge ee) {
public void removeIncoming(Edge ee) {
incoming.remove(ee);
if (incoming.contains(ee)) {
LOG.error("edge {} still in edgelist of {} after removed. there must have been multiple copies.");
LOG.trace("edge {} still in edgelist of {} after removed. there must have been multiple copies.");
}
}

Expand Down

0 comments on commit 6cb9c01

Please sign in to comment.