Itinerary list filter chain refactor #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesj
force-pushed
the
otp2_post_processing_refactor
branch
from
38d26cd
to
3bbe317
Compare
hannesj
changed the title
hannesj
force-pushed
the
otp2_post_processing_refactor
branch
from
3bbe317
to
19b8e7f
Compare
hannesj
commented
Oct 5, 2021
src/main/java/org/opentripplanner/routing/algorithm/filterchain/package.md
Outdated
Show resolved
Hide resolved
t2gran
reviewed
Oct 6, 2021
src/main/java/org/opentripplanner/routing/algorithm/filterchain/ItineraryListFilterChain.java
Outdated
Show resolved
Hide resolved
t2gran
reviewed
Oct 6, 2021
...a/org/opentripplanner/routing/algorithm/filterchain/filter/AddMinSafeTransferCostFilter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Gran <t2gran@gmail.com>
t2gran
reviewed
Oct 6, 2021
src/main/java/org/opentripplanner/routing/algorithm/filterchain/package.md
Show resolved
Hide resolved
t2gran
reviewed
Oct 6, 2021
src/main/java/org/opentripplanner/routing/algorithm/filterchain/package.md
Outdated
Show resolved
Hide resolved
t2gran
reviewed
Oct 6, 2021
src/main/java/org/opentripplanner/routing/algorithm/filterchain/package.md
Outdated
Show resolved
Hide resolved
t2gran
reviewed
Oct 6, 2021
src/main/java/org/opentripplanner/routing/algorithm/filterchain/filter/GroupByFilter.java
Show resolved
Hide resolved
t2gran
reviewed
Oct 6, 2021
...ipplanner/routing/algorithm/filterchain/tagger/RemoveParkAndRideWithMostlyWalkingFilter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Gran <t2gran@gmail.com>
abyrd
reviewed
Oct 7, 2021
src/main/java/org/opentripplanner/routing/algorithm/filterchain/ItineraryListFilter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/algorithm/filterchain/filter/FilteringFilter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/algorithm/filterchain/package.md
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/algorithm/filterchain/tagger/ItineraryTagger.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/algorithm/filterchain/package.md
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/algorithm/filterchain/package.md
Outdated
Show resolved
Hide resolved
hannesj
force-pushed
the
otp2_post_processing_refactor
branch
from
9151f8f
to
69942cd
Compare
t2gran
reviewed
Oct 8, 2021
.../opentripplanner/routing/algorithm/filterchain/deletionflagger/ItineraryDeletionFlagger.java
Show resolved
Hide resolved
t2gran
reviewed
Oct 8, 2021
.../opentripplanner/routing/algorithm/filterchain/deletionflagger/ItineraryDeletionFlagger.java
Show resolved
Hide resolved
Co-authored-by: Thomas Gran <t2gran@gmail.com>
t2gran
approved these changes
Oct 8, 2021
abyrd
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the following refactorings.
FilterChain=>ItineraryListFilterChainSystemNotices always to mark deleted itinerariesItineraryFilterinto four concrete classes implementingItineraryListFilterFilteringFilter, which takes aItineraryTaggeruses it to mark itineraries as deletedSortingFilter, which takes aComparatorand uses it to reorder the itinerariesGroupByFilter, which takes a list ofItineraryListFilters to further process each groupAddMinSafeTransferCost, which is unchangedUnit tests
Updated tests to work with mutable deletion status.
Documentation
Updated documentation and added architecture drawing.
Changelog
Included