Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL utils: add utils from otp-rr for calling OTP and/or pulling up app state #40

Closed
fpurcell opened this issue Jan 23, 2020 · 0 comments · Fixed by #45
Closed

URL utils: add utils from otp-rr for calling OTP and/or pulling up app state #40

fpurcell opened this issue Jan 23, 2020 · 0 comments · Fixed by #45
Assignees
Labels
AS1 enhancement New feature or request MEDIUM Medium Priority

Comments

@fpurcell
Copy link
Member

From this Slack conversation: https://trimet-mod-sandbox.slack.com/archives/CRC48NTJ4/p1579567951000400

There definitely is more nuance to constructing the query params. That logic is contained within here: https://github.com/opentripplanner/otp-react-redux/blob/906d9226553cbbdd83cf455986f199c5a6964f72/lib/actions/api.js#L164-L246

I could move this method over to @opentripplanner/core-utils/src/query if that would be helpful.


Randolph: ... Would be great to get a util that does the opposite (query object to OTP-API string) put in the OTP-UI. I did try and extract the logic from that api module and it got kind of tricky. We would use that module at least twice. Once when talking with the OTP API and another when generating the query params string for trimet.org urls when we need one. If you need anymore details, just let me know. Thanks.

evansiroky
ok ... Can you create a github issue please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AS1 enhancement New feature or request MEDIUM Medium Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants