Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get transitive utility to tolerate itineraries without intermediate stops #42

Merged
merged 3 commits into from
Jan 24, 2020
Merged

Get transitive utility to tolerate itineraries without intermediate stops #42

merged 3 commits into from
Jan 24, 2020

Conversation

evansiroky
Copy link
Contributor

This fixes the bug described in #36. A story has been added to the transitve-overlay package to demonstrate the fix.

fpurcell
fpurcell approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@fpurcell fpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works well. Not sure we have a test / story to test intermediate stops, but logic looks like it'll work.

binh-dam-ibigroup
binh-dam-ibigroup approved these changes Jan 24, 2020
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve; was there a screenshot of the issue at hand?

@fpurcell fpurcell merged commit 7e767ed into opentripplanner:master Jan 24, 2020
@evansiroky evansiroky deleted the transitive-no-intermediate-stops branch January 24, 2020 04:09
@fpurcell fpurcell mentioned this pull request Jan 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpurcell fpurcell fpurcell approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@fpurcell fpurcell

@landonreed landonreed

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evansiroky @fpurcell @binh-dam-ibigroup @landonreed