Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample::ImportFromCSVFile tests should be conditional to bison/flex #1810

Closed
sofianehaddad opened this issue Mar 30, 2021 · 4 comments · Fixed by #1802
Closed

Sample::ImportFromCSVFile tests should be conditional to bison/flex #1810

sofianehaddad opened this issue Mar 30, 2021 · 4 comments · Fixed by #1802
Assignees
@jschueller
Labels
bug
Milestone
1.17

Comments

@sofianehaddad
Copy link
Member

sofianehaddad commented Mar 30, 2021 •
edited

Tests using Sample::ImportFromCSVFile should run only if library has been compiled using bison/flex
This is a minor bug introduced recently with very minor impacts (concerns also some docstring tests)
@jschueller jschueller reopened this Mar 30, 2021
@jschueller
Copy link
Member

anything missing ? abca902

@sofianehaddad
Copy link
Member Author

sofianehaddad commented Mar 30, 2021 •
edited

@jschueller yes, see this . As docstrings are tested, corresponding typ_docstring_test fail (see this check for more details)

@jschueller jschueller self-assigned this Mar 30, 2021
@jschueller jschueller added the bug label Mar 30, 2021
@jschueller jschueller added this to the 1.17 milestone Mar 30, 2021
@jschueller jschueller linked a pull request Mar 30, 2021 that will close this issue
Misc #1802
Merged
jschueller added a commit to jschueller/openturns that referenced this issue Mar 30, 2021
@jschueller
CMake: Disable csv tests
c76ad4f 
Closes openturns#1810
jschueller added a commit to jschueller/openturns that referenced this issue Mar 30, 2021
@jschueller
CMake: Disable csv tests
f4c2dad 
Closes openturns#1810
@sofianehaddad
Copy link
Member Author

t_Sample_csv.cxx should also run only if bison/flex are available

@jschueller
Copy link
Member

it is

@jschueller jschueller mentioned this issue Apr 2, 2021
Merged
jschueller added a commit to jschueller/openturns that referenced this issue Apr 2, 2021
@jschueller
CMake: Disable csv tests
8a329e3 
Closes openturns#1810
jschueller added a commit to jschueller/openturns that referenced this issue Apr 9, 2021
@jschueller
CMake: Disable csv tests
c8fff78 
Closes openturns#1810
jschueller added a commit to jschueller/openturns that referenced this issue Apr 13, 2021
@jschueller
CMake: Disable csv tests
176bb42 
Closes openturns#1810
jschueller added a commit to jschueller/openturns that referenced this issue Apr 15, 2021
@jschueller
CMake: Disable csv tests
a533631 
Closes openturns#1810
jschueller added a commit to jschueller/openturns that referenced this issue Apr 15, 2021
@jschueller
CMake: Disable csv tests
c0a97db 
Closes openturns#1810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jschueller jschueller

Labels
bug
Projects
None yet
Milestone
1.17
Development

Successfully merging a pull request may close this issue.

Misc jschueller/openturns
2 participants
@sofianehaddad @jschueller