Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GaussianProcess.GIBBS #2130

Closed
jschueller opened this issue Sep 5, 2022 · 1 comment · Fixed by #2142
Closed

GaussianProcess.GIBBS #2130

jschueller opened this issue Sep 5, 2022 · 1 comment · Fixed by #2142
Labels
Milestone

Comments

@jschueller
Copy link
Member

jschueller commented Sep 5, 2022

The name ot.GaussianProcess.GIBBS is confusing, because this is not a traditional Gibbs sampler of a Gaussian vector Y with mean 0 and covariance matrix C. It implements the idea, proposed by Galli and Gao (2001) of using a Gibbs sampler to sample from an auxiliary Gaussian vector X with mean 0 and covariance matrix C^{-1}, and then setting Y = C X. What we do is use a smart implementation of that idea given in Ayano and Emery (2020) (thanks for the ref @regislebrun) - see my post below. So maybe we could rename this ot.GaussianProcess.GALLIGAOGIBBS? The doc should also be updated to explain what the method does, or at least provide a reference.

from #2121

@regislebrun
Copy link
Member

regislebrun commented Sep 25, 2022

@jschueller Good idea, let's adopt ot.GaussianProcess.GALLIGAOGIBBS

@jschueller jschueller added this to the 1.20 milestone Sep 26, 2022
jschueller added a commit to jschueller/openturns that referenced this issue Sep 26, 2022
@jschueller jschueller mentioned this issue Sep 26, 2022
jschueller added a commit to jschueller/openturns that referenced this issue Sep 26, 2022
@jschueller jschueller linked a pull request Sep 26, 2022 that will close this issue
jschueller added a commit to jschueller/openturns that referenced this issue Sep 26, 2022
jschueller added a commit to jschueller/openturns that referenced this issue Sep 28, 2022
jschueller added a commit to jschueller/openturns that referenced this issue Sep 30, 2022
jschueller added a commit to jschueller/openturns that referenced this issue Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants