Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calibration wo obs input API #2145

Closed
jschueller opened this issue Sep 28, 2022 · 1 comment · Fixed by #2142
Closed

Calibration wo obs input API #2145

jschueller opened this issue Sep 28, 2022 · 1 comment · Fixed by #2142
Labels
API
Milestone
1.20

Comments

@jschueller
Copy link
Member

I think Calibration classes should allow for an inputObservations argument set via Sample() : ie no need to set the size, any 0-dim sample should be considered as empty. If the class wants to set the size to simplify the code it can do so internally.

simplifies plot_calibration_withoutobservedinputs.py
@jschueller jschueller added the API label Sep 28, 2022
jschueller added a commit to jschueller/openturns that referenced this issue Sep 28, 2022
@jschueller
Calibration: Allow for a dim-0 sample of any size
3ce5958 
Closes openturns#2145
@jschueller jschueller added this to the 1.20 milestone Sep 28, 2022
@jschueller jschueller linked a pull request Sep 28, 2022 that will close this issue
misc 2 #2142
Merged
@jschueller
Copy link
Member Author

jschueller commented Sep 28, 2022 •
edited
Loading

it would have been even simpler if ot.Sample() was of dimension 0 instead of dim 1 :/

jschueller added a commit to jschueller/openturns that referenced this issue Sep 28, 2022
@jschueller
Calibration: Allow for a dim-0 sample of any size
3d18ce1 
Closes openturns#2145
jschueller added a commit to jschueller/openturns that referenced this issue Sep 28, 2022
@jschueller
Calibration: Allow for a dim-0 sample of any size
cdeb41f 
Closes openturns#2145
jschueller added a commit to jschueller/openturns that referenced this issue Sep 29, 2022
@jschueller
Calibration: Allow for a dim-0 sample of any size
5190483 
Closes openturns#2145
jschueller added a commit to jschueller/openturns that referenced this issue Sep 30, 2022
@jschueller
Calibration: Allow for a dim-0 sample of any size
440ee2f 
Closes openturns#2145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
1.20
Development

Successfully merging a pull request may close this issue.

misc 2 jschueller/openturns
1 participant
@jschueller