#3505: add fuel quantity sensor in telemetry simulator #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is helpful if you add text |
|
I would prefer if you put the new sensor below the existing |
| @@ -158,6 +158,7 @@ void TelemetrySimulator::showEvent(QShowEvent *event) | |||
| SET_INSTANCE(t2_inst, T2_FIRST_ID, 0); | |||
| SET_INSTANCE(rpm_inst, RPM_FIRST_ID, DATA_ID_RPM); | |||
| SET_INSTANCE(fuel_inst, FUEL_FIRST_ID, 0); | |||
| SET_INSTANCE(fuel_qty_inst, FUEL_QTY_FIRST_ID, 0); | |||
There was a problem hiding this comment.
Pleas try to keep the alignment, if needed move the tabs on all other lines.
|
Closes #3505 |
|
Expect for minor issues (comments above) the code works good and will be merged as soon as comments are addressed. Thanks! |
|
@projectkk2glider I made the changes, added/updated code from #3507, pushed, but it seems github is rather slow to process new commits sometimes... |
|
Thanks! The code ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed to be missing. I have still no clue why this sensor is supposed to be sent as 0.01ml. Is there any sensor in this world capable to measure that? Should it be changed as well to something more reasonable? (ml is just enough, IMHO)