Avoid conditional directives that split up parts of statements. #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| check_lun = (lun < 1); | ||
| #endif | ||
| if (check_lun) | ||
| { |
|
I am not sure we have a lot of these, but you are right! |
|
There only a few across the source files and some of them in third party code with similar patterns, such as: |
| #endif | ||
| ) | ||
| if (checker) | ||
| { |
|
Umm... Shouldn't we be leaving the 3rd-party libs alone? It's not our job to change them, and would likely cause massive conflicts should we update them. |
bsongis
added a commit
that referenced
this pull request
Nov 26, 2015
Avoid conditional directives that split up parts of statements.
|
Kilrah is right, we change thirdparties to the minimum, but at least the first fix is in some code already modified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners.
It might improve code understanding, maintainability and error-proneness.