New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of multi module support for Taranis #3198
Conversation
The old pull is #3193 |
@@ -442,6 +442,7 @@ if(ARCH STREQUAL ARM) | |||
ppm_arm.cpp | |||
pxx_arm.cpp | |||
dsm2_arm.cpp | |||
multi_arm.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -DMULTIMODULE is needed as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Cmake file is just guessing at the moment. I am trying to get cmake running (include could not find load file: Bitmaps)
When I get it building I will submet a fixed Cmake file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bitmaps.cmake should be in the cmake directory, would you paste the error here so that I can try to help you?
e681c87
to
fe72bb0
Compare
All good, but Travis still fires this error:
I guess sendByteDsm2(...) should be declared in pulses_arm.h |
fe72bb0
to
cb74acf
Compare
Since DSM2 uses the same framing/serial protocol (Serial with 125k) the multi module code heavily reuses that code and depends on it being enabled. This first version only implements the protocol on the taranis. Telemetry code is currently untested.
cb74acf
to
1081390
Compare
Aie I am too late, I will try to find time to resolve conflicts on this one |
@bsongis keep this on hold for the moment. The multimodule changed its protocol to another one in the meantime (16ch and different baudrate). I think it is better if I fix the pull request to use the new protocol. |
Ok! I close it then for now. |
@schwabe, I have look with Pascal for have an option for the serial at 125k in the next release. I am very interested in your work and I thought, looking at your code, it would be interesting to have a text file to define all the protocols / sub-protocols. |
@tipouic Yeah, since they are changing the code to compiled by each user anyway, a specific version for the Taranis is not that problematic as it used to be. I will add version that implements the new protocol in the next few days. |
Yes and no. In serial mode, the id of the protocol / subprotocol are fixed, but added regularly, new protocols forcing recompile the firmware if they are written in code. While they were in a text file (on the SD card, with maybe a privately format), you could easily make day. |
Since DSM2 uses the same framing/serial protocol (Serial with 125k)
the multi module code heavily reuses that code and depends on it being enabled.
This first version only implements the protocol on the taranis.
Telemetry code is currently untested.
Updated version that is based on next branch and should address the issues outlined in the last pull request.