Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SBUS output for external module bay. #5225

Merged
merged 2 commits into from
Sep 29, 2017
Merged

Implement SBUS output for external module bay. #5225

merged 2 commits into from
Sep 29, 2017

Conversation

schwabe
Copy link
Member

@schwabe schwabe commented Sep 19, 2017

No description provided.

@schwabe
Copy link
Member Author

schwabe commented Sep 21, 2017

image
Current implementation how warn users of the voltage level when SBUS is selected.

@yanivasy
Copy link

By using the battery UART port as an another alternative for the SBUS output, its possible to get standard SBUS voltage levels.

If a beta version was already implemented, I'll be happy to test it give a feedback.

@kilrah
Copy link
Member

kilrah commented Sep 28, 2017

Since the pull request hasn't been merged yet you need to build yourself.

addConversion(PULSES_CROSSFIRE, val++);
addConversion(PULSES_MULTIMODULE, val++);
addConversion(PULSES_PXX_R9M, val++);
}
else if (IS_ARM(board)) {
val++;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was for removing CROSSFIRE support from SKY9X but perhaps we could add it soon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but it only does the mapping. If a protocol is actually availabe is on another place. And on the Sky9x and Taranis the eeprom ids are identical anyway, so I remove that distinction.

#define IS_MODULE_SBUS(idx) (idx==EXTERNAL_MODULE && g_model.moduleData[EXTERNAL_MODULE].type==MODULE_TYPE_SBUS)
#else
#define IS_MODULE_DSM2(idx) (false)
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no IS_MODULE_SBUS() here?

@bsongis bsongis merged commit fd78253 into 2.2 Sep 29, 2017
@bsongis bsongis deleted the schwabe/sbus branch September 29, 2017 16:29
@yanivasy
Copy link

@bsongis , from what I see, your version in #2894 was using the S. Port pin which later was used for CrossFire modules.
Correct me if I'm wrong but @schwabe new version uses the PPM pin.

@bsongis
Copy link
Member

bsongis commented Sep 30, 2017

Crossfire and SBUS are not the same protocol, Crossfire is bidirectional

@yanivasy
Copy link

Crossfire and SBUS are not the same protocol, Crossfire is bidirectional

@bsongis , I never claimed that (see my first comment on #5236). Just wanted to point out to difference in implementation of SBUS output with your version a couple of years ago and @schwabe's version now a days.

@yanivasy
Copy link

I'll be very grateful for a compiled build for Taranis+ X9D plus along with Multimodule (including SBUS) & sqt5font as build options for testing

@schwabe
Copy link
Member Author

schwabe commented Sep 30, 2017

Just download the nightly build it has sbus already in it

@yanivasy
Copy link

yanivasy commented Oct 1, 2017

Just download the nightly build it has sbus already in it

@schwabe , Starting from Nightly build companion-windows-2.2.1N391.exe ( thru 2.2.1N392 and including latest 2.2.1N393) there is a problem with Companion updates.

A popup error with "Unable to check for updates" appears.

(Although I set "Use firmware nightly builds" & "Use Companion nightly builds" check box within the "Application Settings" tab).

Currently I was able to build only using 2.2.1N390 or an older version of Companion (for windows).
I double checked it with two different OS (win7 & win10).

@schwabe
Copy link
Member Author

schwabe commented Oct 1, 2017

@yanivasy There is a problem with SSL in newer update url. Just install a firmware from your N390, the build server should still give you a current nightly

@yanivasy
Copy link

I've tested the sbus functionality with Taranis+and it working well. Thank's a lot.
Please include the SBUS output feature within 2.2.1.

@3djc
Copy link
Contributor

3djc commented Oct 28, 2017

Since it is merged, it will be in 2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants