Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes
UCT_IFACE_FLAG_CONNECT_TO_IFACE
fromiface_attr.flags
.Why ?
My understanding is that
UCT_IFACE_FLAG_CONNECT_TO_EP
andUCT_IFACE_FLAG_CONNECT_TO_IFACE
iniface_attr.cap.flags
are mutually exclusive(As written in
uct_hello_world.c
)https://github.com/openucx/ucx/blob/master/src/uct/ib/dc/base/dc_iface.c#L343
However, in
ib/ud
, both of the flags are ON.