CONFIG: Fix bashisms in configure.ac, config/m4/go.m4 #8494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how I can satisfy the commit message style checker for this change. |
|
@thesamesam, thanks for the bugfix ! Here the guidance how to structure your contribution and commit messages: We also ask contributors to sign CLA: https://openucx.org/license/ Hopefully this helps ! |
shamisp
changed the title
configure scripts need to be runnable with a POSIX-compliant /bin/sh. On many (but not all!) systems, /bin/sh is provided by Bash, so errors like this aren't spotted. Notably Debian defaults to /bin/sh provided by dash which doesn't tolerate such bashisms as '=='. This retains compatibility with bash. Fixes configure warnings/errors like: ``` checking for go... yes ./configure: 26781: test: xyes: unexpected operator ``` Signed-off-by: Sam James <sam@gentoo.org>
|
Thanks @shamisp. I emailed my CLA earlier today. Hopefully this looks OK now. |
yosefe
approved these changes
Sep 4, 2022
|
We have received the CLA |
shamisp
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure scripts need to be runnable with a POSIX-compliant /bin/sh.
On many (but not all!) systems, /bin/sh is provided by Bash, so errors
like this aren't spotted. Notably Debian defaults to /bin/sh provided
by dash which doesn't tolerate such bashisms as '=='.
This retains compatibility with bash.
Fixes configure warnings/errors like:
Signed-off-by: Sam James sam@gentoo.org
What
Remove Bashisms from the build system which cause issues
when
/bin/shis not Bash, but is a POSIX-compliant shell.Why ?
The build may be misconfigured or fail with a POSIX-compliant-but-not-Bash
/bin/sh.