Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCP/RNDV/PUT: Replace request ATP/flush lane map with lane indexes #9862

Merged

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented May 4, 2024

Why

Allow keeping same request size if increasing max lanes

@yosefe
Copy link
Contributor Author

yosefe commented May 4, 2024

@ivankochin @brminich can you pls take a look?

src/ucp/core/ucp_request.h Show resolved Hide resolved
src/ucp/rndv/rndv_put.c Show resolved Hide resolved
Copy link
Contributor

@tvegas1 tvegas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem we need to fix commit and pr typo APT -> ATP when squashing

@yosefe yosefe force-pushed the topic/ucp-rndv-put-replace-request-apt-flush branch from 427ae10 to e7376a8 Compare May 6, 2024 09:48
@yosefe yosefe changed the title UCP/RNDV/PUT: Replace request APT/flush lane map with lane indexes UCP/RNDV/PUT: Replace request ATP/flush lane map with lane indexes May 6, 2024
@yosefe
Copy link
Contributor Author

yosefe commented May 6, 2024

seem we need to fix commit and pr typo APT -> ATP when squashing

done

@yosefe yosefe enabled auto-merge May 6, 2024 11:53
@yosefe yosefe merged commit 33089b3 into openucx:master May 6, 2024
140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants