-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Approach for Popup #455
Comments
Only note I would have is "accessible by default" seems like something that is likely within reason. A point of clarity here would be that an element with a role of All that said, I really like this @mfreed7. |
So this new approach was discussed last week at OpenUI. I generally heard supportive comments, and didn't hear any (at least major) objections to the new approach. I'd really like to kick the tires by re-implementing the Chromium |
@mfreed7 issues here or with your explainer doc? from my memory, the topic of |
Either way works for me! I'll try to listen to both and incorporate them back into the explainer.
Yep, this is a great point, thanks for the reminder. I had indeed taken a note to possibly change to an |
I've updated the explainer to use |
The Open UI Community Group just discussed
The full IRC log of that discussion<gregwhitworth> Topic: New Approach for Popup<gregwhitworth> github: https://github.com//issues/455 <hdv> masonf: the main thing I want to get out of this meeting… I presented a new approach to popup that is based on a content attribute as opposed to a new element <hdv> masonf: the comments I heard were generally positive, so the main thing I want to discuss is… are there any major killer issue that cause it to be not a viable, valid proposal <hdv> masonf: because the next thing I'd like to do is update the prototype in Chromium <hdv> masonf: a lot of people have raised great issues, they are in my repo btw, will probably move to open ui repo <hdv> masonf: would love to hear more comments if people have them <masonf> Proposed resolution: The general shape of the `popup` content attribute proposal looks good, and we are ok to start prototyping. <davidluhr> Our work is done here, Dave gave the thumbs up. <hdv> dave: do it! <una> LGTM <hdv> chris: I'd like to second that <hdv> masonf: we're trying to get to the point where we found most issues there are with it <hdv> davatron5000: are you happy with it, Mason? <gregwhitworth> RESOLVED: The general shape of the `popup` content attribute proposal looks good, and we are ok to start prototyping. <hdv> masonf: yes, I'm happier with it than the element and it feels very implementable to me |
@mfreed7 , I'm closing this issue on account of the Telecon resolution. Feel free to re-open if you'd like to continue the discussion here 😄 |
There has been extensive debate (e.g. #410 and #417, plus numerous OpenUI meeting discussions) about the
<popup>
element proposal. That proposal got "stuck" on what appear to be some rather fundamental questions about the semantics and associated AX roles for this new element.As a result of these issues, we've put together a fresh proposal for a new way to achieve (roughly) the same list of goals. This new proposal introduces an HTML attribute syntax that allows any element to be made into a "popup" that gets rendered on top of all other page content:
Here, the
popup
attribute is set to a value ofpopup
(other values includehint
andasync
) to indicate "popup" behaviors should be applied. That includes:popup
attribute.)Additionally, another HTML attribute,
triggerpopup
, can be used for declarative triggering, so that this API can be used without any JavaScript required:In this case, the
<my-date-picker
> component starts outhidden
, but when the<button>
is clicked, the UA removeshidden
from<my-date-picker
> and the date picker is shown. As with all popups, once the user clicks outside, hits Esc, etc., the UA will light-dismiss it by adding back thehidden
attribute.Please take a look at the new proposal, and add your comments here to this issue. Pull requests for changes are also great.
The text was updated successfully, but these errors were encountered: