Add stepUp and stepDown actions for number inputs #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luke Plant <luke@lukeplant.me.uk>
lukewarlow
requested review from
keithamus,
gregwhitworth,
mfreed7 and
dbaron
as code owners
lukewarlow
commented
Apr 5, 2024
| @@ -311,6 +311,8 @@ Invokers, the names and exact semantics may be subject to change: | |||
| | `<*>` | `'toggleFullscreen'` | If the element is fullscreen, then exit, otherwise request to enter | | |||
| | `<*>` | `'requestFullscreen'` | Request the element to enter into 'fullscreen' mode | | |||
| | `<*>` | `'exitFullscreen'` | Request the element to exit 'fullscreen' mode | | |||
| | `<input type=number>` | `'stepUp'` | Call `.stepUp()` on the invokee | | |||
There was a problem hiding this comment.
stepUp and stepDown take an argument which is multiplied by the step attribute. Should invokers handle that somehow? Thinking maybe the button value attribute can be used as the argument?
We have precedence for the dialog returnValue?
There was a problem hiding this comment.
I think it'd be best to avoid getting more complicated on things like this. The number already has a step, so the most natural argument is 1 - step by 1.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 5, 2024
This adds a stepUp and stepDown invoke action for number inputs. See: openui/open-ui#1029 Bug: 40284894 Change-Id: I5d8ae99e31181125f872254b6f87b1579dfd5bef
mfreed7
approved these changes
Apr 5, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 5, 2024
This adds a stepUp and stepDown invoke action for number inputs. See: openui/open-ui#1029 Bug: 40284894 Change-Id: I5d8ae99e31181125f872254b6f87b1579dfd5bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425043 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1283459}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 5, 2024
This adds a stepUp and stepDown invoke action for number inputs. See: openui/open-ui#1029 Bug: 40284894 Change-Id: I5d8ae99e31181125f872254b6f87b1579dfd5bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425043 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1283459}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 6, 2024
This adds a stepUp and stepDown invoke action for number inputs. See: openui/open-ui#1029 Bug: 40284894 Change-Id: I5d8ae99e31181125f872254b6f87b1579dfd5bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425043 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1283459}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 15, 2024
…ions, a=testonly Automatic update from web-platform-tests Implement stepUp and stepDown invoke actions This adds a stepUp and stepDown invoke action for number inputs. See: openui/open-ui#1029 Bug: 40284894 Change-Id: I5d8ae99e31181125f872254b6f87b1579dfd5bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425043 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1283459} -- wpt-commits: f8fb78a2c237eeb8064d2c94a2f3ac9842bd348b wpt-pr: 45580
ErichDonGubler
pushed a commit
to ErichDonGubler/firefox
that referenced
this pull request
Apr 16, 2024
…ions, a=testonly Automatic update from web-platform-tests Implement stepUp and stepDown invoke actions This adds a stepUp and stepDown invoke action for number inputs. See: openui/open-ui#1029 Bug: 40284894 Change-Id: I5d8ae99e31181125f872254b6f87b1579dfd5bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425043 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1283459} -- wpt-commits: f8fb78a2c237eeb8064d2c94a2f3ac9842bd348b wpt-pr: 45580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #968
Closes #967
Definitely needs some thought with regards to aria mappings that perhaps @scottaohara could help with. But think it's a good idea to get these listed as future so we do address them.